Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Process Delta logic #111

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

vaibhavjainwiz
Copy link
Contributor

@vaibhavjainwiz vaibhavjainwiz commented Oct 26, 2023

Description

InferenceService namespace are not adding into SMMR because issue in Delta identification logic.
odh-model-controller manifest referred in below testing instructions are already contains changes of #110. So by testing this PR, changes of #110 would be verified as well.

How Has This Been Tested?

kind: DataScienceCluster
apiVersion: datasciencecluster.opendatahub.io/v1
metadata:
  labels:
    app.kubernetes.io/created-by: opendatahub-operator
    app.kubernetes.io/instance: default
    app.kubernetes.io/managed-by: kustomize
    app.kubernetes.io/name: datasciencecluster
    app.kubernetes.io/part-of: opendatahub-operator
  name: default
  namespace: opendatahub
spec:
  components:
    kserve:
      managementState: Managed
      devFlags:
        manifests:
          - contextDir: config
            sourcePath: overlays/odh
            uri: 'https://github.com/opendatahub-io/kserve/tarball/master'
          - contextDir: config
            uri: 'https://github.com/vaibhavjainwiz/odh-model-controller/tarball/fix_reconciler_manifest'  
    modelmeshserving:
      managementState: Managed
      devFlags:
        manifests:
          - contextDir: config
            sourcePath: overlays/odh
            uri: 'https://github.com/opendatahub-io/modelmesh-serving/tarball/main'
          - contextDir: config
            uri: 'https://github.com/vaibhavjainwiz/odh-model-controller/tarball/fix_reconciler_manifest'

If everything work as mentioned in above step then we are good to go :)

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Vaibhav Jain <vajain@redhat.com>
@vaibhavjainwiz vaibhavjainwiz linked an issue Oct 26, 2023 that may be closed by this pull request
@rpancham rpancham mentioned this pull request Oct 26, 2023
3 tasks
@rpancham
Copy link
Contributor

I have verified the changes by deploying KServe model on new ROSA cluster.

Copy link
Member

@spolti spolti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good, approving by comment instead adding approve label :)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, vaibhavjainwiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit bdec174 into opendatahub-io:main Oct 26, 2023
5 checks passed
@vaibhavjainwiz vaibhavjainwiz deleted the fix_reconciler branch December 1, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on reconciliation of odh-model-controller
4 participants