Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing resources to manage in DSC controller #637

Closed
VaishnaviHire opened this issue Oct 17, 2023 · 5 comments
Closed

Add missing resources to manage in DSC controller #637

VaishnaviHire opened this issue Oct 17, 2023 · 5 comments
Assignees
@ykaliuta
Labels
bug Something isn't working odh-2.5 rhods-2.5

Comments

@VaishnaviHire
Copy link
Member

VaishnaviHire commented Oct 17, 2023 •
edited

Is your feature request related to a problem? Please describe.
Currently operator is managing resources it creates, however it doesn't reconcile on update/deletion of resources if they are not listed as Owns under SetupWithManager function.

Describe the solution you'd like
Extend the list of resources to include resource types previously defined in v1 -
List of resource types

Additional context
One of the tests that we can perform to verify the change is to ensure the resources that are not previously in the list get recreated on deletion -

  1. Deploy operator image with changes
  2. Set workbenches component to Managed in DSC instance
  3. Delete any Imagestream under opendatahub namespace.
  4. Verify if the Imagestream gets recreated.
@VaishnaviHire VaishnaviHire added the enhancement New feature or request label Oct 17, 2023
@VaishnaviHire VaishnaviHire added rhods-1.35 bug Something isn't working and removed enhancement New feature or request labels Oct 17, 2023
ykaliuta added a commit to ykaliuta/opendatahub-operator that referenced this issue Oct 26, 2023
@ykaliuta
rbac: add permissions for imagestreams, daemonsets, apiservices
04b11a0 
Prepare for watching v1 resources (issue opendatahub-io#637)

To enable watching for DaemonSet and APIService (REST api resources
daemonsets and apiservices) reading/watching permissions required
for the operator's role. Otherwise it gets errors like:

```
User "system:serviceaccount:openshift-operators:opendatahub-operator-controller-manager" cannot list resource "daemonsets" in API group "apps" at the cluster scope

E1018 20:00:55.374514       1 reflector.go:140] go/pkg/mod/k8s.io/client-go@v0.26.0/tools/cache/reflector.go:169: Failed to watch *v1.DaemonSet: failed to list *v1.DaemonSet: daemonsets.apps is forbidden: User "system:serviceaccount:openshift-operators:opendatahub-operator-controller-manager" cannot list resource "daemonsets" in API group "apps" at the cluster scope
```

For ImageStream `get` permissing is needed for cli.Get() in deploy's
manageResources()[1], otherwise it does not set
ownersReference (missing the branch apierrs.IsNotFound(err) since
err is related to permissions).

[1] https://github.com/opendatahub-io/opendatahub-operator/blob/13a7e822c0c75f361c319f8256a2d199d031d97c/pkg/deploy/deploy.go#L199

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
ykaliuta added a commit to ykaliuta/opendatahub-operator that referenced this issue Oct 26, 2023
@ykaliuta
rbac: add permissions for imagestreams, daemonsets, apiservices
1ee972e 
Prepare for watching v1 resources (issue opendatahub-io#637)

To enable watching for DaemonSet and APIService (REST api resources
daemonsets and apiservices) reading/watching permissions required
for the operator's role. Otherwise it gets errors like:

```
User "system:serviceaccount:openshift-operators:opendatahub-operator-controller-manager" cannot list resource "daemonsets" in API group "apps" at the cluster scope

E1018 20:00:55.374514       1 reflector.go:140] go/pkg/mod/k8s.io/client-go@v0.26.0/tools/cache/reflector.go:169: Failed to watch *v1.DaemonSet: failed to list *v1.DaemonSet: daemonsets.apps is forbidden: User "system:serviceaccount:openshift-operators:opendatahub-operator-controller-manager" cannot list resource "daemonsets" in API group "apps" at the cluster scope
```

For ImageStream `get` permissing is needed for cli.Get() in deploy's
manageResources()[1], otherwise it does not set
ownersReference (missing the branch apierrs.IsNotFound(err) since
err is related to permissions).

Autogenerated files:
- config/rbac/role.yaml

[1] https://github.com/opendatahub-io/opendatahub-operator/blob/13a7e822c0c75f361c319f8256a2d199d031d97c/pkg/deploy/deploy.go#L199

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
ykaliuta added a commit to ykaliuta/opendatahub-operator that referenced this issue Oct 26, 2023
@ykaliuta
DSC controller: manage missing resources previously defined v1
90ceb35 
Add the following resources to manage:

- PersistentVolumeClaim
- Service
- DaemonSet
- StatefulSet
- DeploymentConfig
- ImageStream
- BuildConfig
- CustomResourceDefinition
- APIService
- Ingress
- MutatingWebhookConfiguration
- ValidatingWebhookConfiguration
- ServiceAccount

It requires to add them to the scheme in main.go.
Also `go mod tidy` is run to update modules information to make it
buildable (keep bisectable).

Autogenerated files:
- go.mod
- go.sum

Closes: opendatahub-io#637

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
@ykaliuta
Copy link
Contributor

is label rhods-1.35 correct here?

ykaliuta added a commit to ykaliuta/opendatahub-operator that referenced this issue Oct 26, 2023
@ykaliuta
rbac: add permissions for imagestreams, daemonsets, apiservices
a4b46cf 
Prepare for watching v1 resources (issue opendatahub-io#637)

To enable watching for DaemonSet and APIService (REST api resources
daemonsets and apiservices) reading/watching permissions required
for the operator's role. Otherwise it gets errors like:

```
User "system:serviceaccount:openshift-operators:opendatahub-operator-controller-manager" cannot list resource "daemonsets" in API group "apps" at the cluster scope

E1018 20:00:55.374514       1 reflector.go:140] go/pkg/mod/k8s.io/client-go@v0.26.0/tools/cache/reflector.go:169: Failed to watch *v1.DaemonSet: failed to list *v1.DaemonSet: daemonsets.apps is forbidden: User "system:serviceaccount:openshift-operators:opendatahub-operator-controller-manager" cannot list resource "daemonsets" in API group "apps" at the cluster scope
```

For ImageStream `get` permissing is needed for cli.Get() in deploy's
manageResources()[1], otherwise it does not set
ownersReference (missing the branch apierrs.IsNotFound(err) since
err is related to permissions).

Autogenerated files:
- config/rbac/role.yaml (make manifests)

[1] https://github.com/opendatahub-io/opendatahub-operator/blob/13a7e822c0c75f361c319f8256a2d199d031d97c/pkg/deploy/deploy.go#L199

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
ykaliuta added a commit to ykaliuta/opendatahub-operator that referenced this issue Oct 26, 2023
@ykaliuta
DSC controller: manage missing resources previously defined v1
0dcc38f 
Add the following resources to manage:

- PersistentVolumeClaim
- Service
- DaemonSet
- StatefulSet
- DeploymentConfig
- ImageStream
- BuildConfig
- CustomResourceDefinition
- APIService
- Ingress
- MutatingWebhookConfiguration
- ValidatingWebhookConfiguration
- ServiceAccount

It requires to add them to the scheme in main.go.
Also `go mod tidy` is run to update modules information to make it
buildable (keep bisectable).

Autogenerated files:
- go.mod
- go.sum

Closes: opendatahub-io#637

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
@zdtsw
Copy link
Member

zdtsw commented Oct 26, 2023

is label rhods-1.35 correct here?

should be 2.4.
do you want to get it in 1.35/2.4 ? or 2.5 ?

@ykaliuta
Copy link
Contributor

ykaliuta commented Oct 26, 2023 •
edited

is label rhods-1.35 correct here?

do you want to get it in 1.35/2.4 ? or 2.5 ?

Well, as soon as it gets integration. Will be safe to put 2.5 or 2.4 still sounds feasible?

UPD: looking at the rush with 2.4 probably it's better to plan it for 2.5

@zdtsw
Copy link
Member

zdtsw commented Nov 3, 2023

ref #613

@zdtsw zdtsw mentioned this issue Nov 3, 2023
Closed
ykaliuta added a commit to ykaliuta/opendatahub-operator that referenced this issue Nov 5, 2023
@ykaliuta
rbac: add permissions for imagestreams, daemonsets, apiservices
cf40712 
Prepare for watching v1 resources (issue opendatahub-io#637)

To enable watching for DaemonSet and APIService (REST api resources
daemonsets and apiservices) reading/watching permissions required
for the operator's role. Otherwise it gets errors like:

```
User "system:serviceaccount:openshift-operators:opendatahub-operator-controller-manager" cannot list resource "daemonsets" in API group "apps" at the cluster scope

E1018 20:00:55.374514       1 reflector.go:140] go/pkg/mod/k8s.io/client-go@v0.26.0/tools/cache/reflector.go:169: Failed to watch *v1.DaemonSet: failed to list *v1.DaemonSet: daemonsets.apps is forbidden: User "system:serviceaccount:openshift-operators:opendatahub-operator-controller-manager" cannot list resource "daemonsets" in API group "apps" at the cluster scope
```

For ImageStream `get` permissing is needed for cli.Get() in deploy's
manageResources()[1], otherwise it does not set
ownersReference (missing the branch apierrs.IsNotFound(err) since
err is related to permissions).

Autogenerated files:
- config/rbac/role.yaml (make manifests)

[1] https://github.com/opendatahub-io/opendatahub-operator/blob/13a7e822c0c75f361c319f8256a2d199d031d97c/pkg/deploy/deploy.go#L199

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
ykaliuta added a commit to ykaliuta/opendatahub-operator that referenced this issue Nov 5, 2023
@ykaliuta
DSC controller: manage missing resources previously defined v1
bd6a46e 
Add the following resources to manage:

- PersistentVolumeClaim
- Service
- DaemonSet
- StatefulSet
- DeploymentConfig
- ImageStream
- BuildConfig
- CustomResourceDefinition
- APIService
- Ingress
- MutatingWebhookConfiguration
- ValidatingWebhookConfiguration
- ServiceAccount

It requires to add them to the scheme in main.go.
Also `go mod tidy` is run to update modules information to make it
buildable (keep bisectable).

Autogenerated files:
- go.mod
- go.sum

Closes: opendatahub-io#637

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
@zdtsw zdtsw mentioned this issue Nov 6, 2023
Closed
@zdtsw
Copy link
Member

zdtsw commented Nov 6, 2023

PR613 did ont get into rhods-2.4 but does in odh-2.4
since we will not have test on odh-2.4, move label to odh-2.5 and rhods-2.5 instead.

ykaliuta added a commit to ykaliuta/opendatahub-operator that referenced this issue Nov 7, 2023
@ykaliuta
rbac: add permissions for imagestreams, daemonsets, apiservices
66c69fb 
Prepare for watching v1 resources (issue opendatahub-io#637)

To enable watching for DaemonSet and APIService (REST api resources
daemonsets and apiservices) reading/watching permissions required
for the operator's role. Otherwise it gets errors like:

```
User "system:serviceaccount:openshift-operators:opendatahub-operator-controller-manager" cannot list resource "daemonsets" in API group "apps" at the cluster scope

E1018 20:00:55.374514       1 reflector.go:140] go/pkg/mod/k8s.io/client-go@v0.26.0/tools/cache/reflector.go:169: Failed to watch *v1.DaemonSet: failed to list *v1.DaemonSet: daemonsets.apps is forbidden: User "system:serviceaccount:openshift-operators:opendatahub-operator-controller-manager" cannot list resource "daemonsets" in API group "apps" at the cluster scope
```

For ImageStream `get` permissing is needed for cli.Get() in deploy's
manageResources()[1], otherwise it does not set
ownersReference (missing the branch apierrs.IsNotFound(err) since
err is related to permissions).

Autogenerated files:
- config/rbac/role.yaml (make manifests)

[1] https://github.com/opendatahub-io/opendatahub-operator/blob/13a7e822c0c75f361c319f8256a2d199d031d97c/pkg/deploy/deploy.go#L199

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
ykaliuta added a commit to ykaliuta/opendatahub-operator that referenced this issue Nov 7, 2023
@ykaliuta
DSC controller: manage missing resources previously defined v1
e42daa2 
Add the following resources to manage:

- PersistentVolumeClaim
- Service
- DaemonSet
- StatefulSet
- DeploymentConfig
- ImageStream
- BuildConfig
- CustomResourceDefinition
- APIService
- Ingress
- MutatingWebhookConfiguration
- ValidatingWebhookConfiguration
- ServiceAccount

It requires to add them to the scheme in main.go.
Also `go mod tidy` is run to update modules information to make it
buildable (keep bisectable).

Autogenerated files:
- go.mod
- go.sum

Closes: opendatahub-io#637

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
ykaliuta added a commit to ykaliuta/opendatahub-operator that referenced this issue Nov 7, 2023
@ykaliuta
DSC controller: manage missing resources previously defined v1
63f51a4 
Add the following resources to manage:

- PersistentVolumeClaim
- Service
- DaemonSet
- StatefulSet
- DeploymentConfig
- ImageStream
- BuildConfig
- CustomResourceDefinition
- APIService
- Ingress
- MutatingWebhookConfiguration
- ValidatingWebhookConfiguration
- ServiceAccount

It requires to add them to the scheme in main.go.
Also `go mod tidy` is run to update modules information to make it
buildable (keep bisectable).

Autogenerated files:
- go.mod
- go.sum

Closes: opendatahub-io#637

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
ykaliuta added a commit to ykaliuta/opendatahub-operator that referenced this issue Nov 7, 2023
@ykaliuta
DSC controller: manage missing resources previously defined v1
9640e18 
Add the following resources to manage:

- PersistentVolumeClaim
- Service
- DaemonSet
- StatefulSet
- DeploymentConfig
- ImageStream
- BuildConfig
- CustomResourceDefinition
- APIService
- Ingress
- MutatingWebhookConfiguration
- ValidatingWebhookConfiguration
- ServiceAccount

It requires to add them to the scheme in main.go.
Also `go mod tidy` is run to update modules information to make it
buildable (keep bisectable).

Autogenerated files:
- go.mod
- go.sum

Closes: opendatahub-io#637

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
ykaliuta added a commit to ykaliuta/opendatahub-operator that referenced this issue Nov 7, 2023
@ykaliuta
DSC controller: manage missing resources previously defined v1
6928299 
Add the following resources to manage:

- PersistentVolumeClaim
- Service
- DaemonSet
- StatefulSet
- DeploymentConfig
- ImageStream
- BuildConfig
- CustomResourceDefinition
- APIService
- Ingress
- MutatingWebhookConfiguration
- ValidatingWebhookConfiguration
- ServiceAccount

It requires to add them to the scheme in main.go.
Also `go mod tidy` is run to update modules information to make it
buildable (keep bisectable).

Autogenerated files:
- go.mod
- go.sum

Closes: opendatahub-io#637

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
ykaliuta added a commit to ykaliuta/opendatahub-operator that referenced this issue Nov 7, 2023
@ykaliuta
DSC controller: manage missing resources previously defined v1
6ded157 
Add the following resources to manage:

- PersistentVolumeClaim
- Service
- DaemonSet
- StatefulSet
- DeploymentConfig
- ImageStream
- BuildConfig
- CustomResourceDefinition
- APIService
- Ingress
- MutatingWebhookConfiguration
- ValidatingWebhookConfiguration
- ServiceAccount

It requires to add them to the scheme in main.go.
Also `go mod tidy` is run to update modules information to make it
buildable (keep bisectable).

Autogenerated files:
- go.mod
- go.sum

Closes: opendatahub-io#637

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
ykaliuta added a commit to ykaliuta/opendatahub-operator that referenced this issue Nov 7, 2023
@ykaliuta
DSC controller: manage missing resources previously defined v1
ccffe5a 
Add the following resources to manage:

- PersistentVolumeClaim
- Service
- DaemonSet
- StatefulSet
- DeploymentConfig
- ImageStream
- BuildConfig
- CustomResourceDefinition
- APIService
- Ingress
- MutatingWebhookConfiguration
- ValidatingWebhookConfiguration
- ServiceAccount

It requires to add them to the scheme in main.go.
Also `go mod tidy` is run to update modules information to make it
buildable (keep bisectable).

Autogenerated files:
- go.mod
- go.sum

Closes: opendatahub-io#637

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
ykaliuta added a commit to ykaliuta/opendatahub-operator that referenced this issue Nov 8, 2023
@ykaliuta
rbac: add permissions for imagestreams, daemonsets, apiservices
aae8aa7 
Prepare for watching v1 resources (issue opendatahub-io#637)

To enable watching for DaemonSet and APIService (REST api resources
daemonsets and apiservices) reading/watching permissions required
for the operator's role. Otherwise it gets errors like:

```
User "system:serviceaccount:openshift-operators:opendatahub-operator-controller-manager" cannot list resource "daemonsets" in API group "apps" at the cluster scope

E1018 20:00:55.374514       1 reflector.go:140] go/pkg/mod/k8s.io/client-go@v0.26.0/tools/cache/reflector.go:169: Failed to watch *v1.DaemonSet: failed to list *v1.DaemonSet: daemonsets.apps is forbidden: User "system:serviceaccount:openshift-operators:opendatahub-operator-controller-manager" cannot list resource "daemonsets" in API group "apps" at the cluster scope
```

For ImageStream `get` permissing is needed for cli.Get() in deploy's
manageResources()[1], otherwise it does not set
ownersReference (missing the branch apierrs.IsNotFound(err) since
err is related to permissions).

Autogenerated files:
- config/rbac/role.yaml (make manifests)
-
bundle/manifests/opendatahub-operator.clusterserviceversion.yaml (make bundle)

[1] https://github.com/opendatahub-io/opendatahub-operator/blob/13a7e822c0c75f361c319f8256a2d199d031d97c/pkg/deploy/deploy.go#L199

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
ykaliuta added a commit to ykaliuta/opendatahub-operator that referenced this issue Nov 8, 2023
@ykaliuta
DSC controller: manage missing resources previously defined v1
9a487ed 
Add the following resources to manage:

- PersistentVolumeClaim
- Service
- DaemonSet
- StatefulSet
- DeploymentConfig
- ImageStream
- BuildConfig
- CustomResourceDefinition
- APIService
- Ingress
- MutatingWebhookConfiguration
- ValidatingWebhookConfiguration
- ServiceAccount

It requires to add them to the scheme in main.go.
Also `go mod tidy` is run to update modules information to make it
buildable (keep bisectable).

Autogenerated files:
- go.mod
- go.sum

Closes: opendatahub-io#637

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
ykaliuta added a commit to ykaliuta/opendatahub-operator that referenced this issue Nov 8, 2023
@ykaliuta
rbac: add permissions for imagestreams, daemonsets, apiservices
a49132c 
Prepare for watching v1 resources (issue opendatahub-io#637)

To enable watching for DaemonSet and APIService (REST api resources
daemonsets and apiservices) reading/watching permissions required
for the operator's role. Otherwise it gets errors like:

```
User "system:serviceaccount:openshift-operators:opendatahub-operator-controller-manager" cannot list resource "daemonsets" in API group "apps" at the cluster scope

E1018 20:00:55.374514       1 reflector.go:140] go/pkg/mod/k8s.io/client-go@v0.26.0/tools/cache/reflector.go:169: Failed to watch *v1.DaemonSet: failed to list *v1.DaemonSet: daemonsets.apps is forbidden: User "system:serviceaccount:openshift-operators:opendatahub-operator-controller-manager" cannot list resource "daemonsets" in API group "apps" at the cluster scope
```

For ImageStream `get` permissing is needed for cli.Get() in deploy's
manageResources()[1], otherwise it does not set
ownersReference (missing the branch apierrs.IsNotFound(err) since
err is related to permissions).

Autogenerated files:
- config/rbac/role.yaml (make manifests)
-
bundle/manifests/opendatahub-operator.clusterserviceversion.yaml (make bundle)

[1] https://github.com/opendatahub-io/opendatahub-operator/blob/13a7e822c0c75f361c319f8256a2d199d031d97c/pkg/deploy/deploy.go#L199

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
ykaliuta added a commit to ykaliuta/opendatahub-operator that referenced this issue Nov 8, 2023
@ykaliuta
DSC controller: manage missing resources previously defined v1
87ee851 
Add the following resources to manage:

- PersistentVolumeClaim
- Service
- DaemonSet
- StatefulSet
- DeploymentConfig
- ImageStream
- BuildConfig
- CustomResourceDefinition
- APIService
- Ingress
- MutatingWebhookConfiguration
- ValidatingWebhookConfiguration
- ServiceAccount

It requires to add them to the scheme in main.go.
Also `go mod tidy` is run to update modules information to make it
buildable (keep bisectable).

Autogenerated files:
- go.mod
- go.sum

Closes: opendatahub-io#637

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
ykaliuta added a commit to ykaliuta/opendatahub-operator that referenced this issue Nov 9, 2023
@ykaliuta
rbac: add permissions for imagestreams, daemonsets, apiservices
cb5c0fa 
Prepare for watching v1 resources (issue opendatahub-io#637)

To enable watching for DaemonSet and APIService (REST api resources
daemonsets and apiservices) reading/watching permissions required
for the operator's role. Otherwise it gets errors like:

```
User "system:serviceaccount:openshift-operators:opendatahub-operator-controller-manager" cannot list resource "daemonsets" in API group "apps" at the cluster scope

E1018 20:00:55.374514       1 reflector.go:140] go/pkg/mod/k8s.io/client-go@v0.26.0/tools/cache/reflector.go:169: Failed to watch *v1.DaemonSet: failed to list *v1.DaemonSet: daemonsets.apps is forbidden: User "system:serviceaccount:openshift-operators:opendatahub-operator-controller-manager" cannot list resource "daemonsets" in API group "apps" at the cluster scope
```

For ImageStream `get` permissing is needed for cli.Get() in deploy's
manageResources()[1], otherwise it does not set
ownersReference (missing the branch apierrs.IsNotFound(err) since
err is related to permissions).

Autogenerated files:
- config/rbac/role.yaml (make manifests)
-
bundle/manifests/opendatahub-operator.clusterserviceversion.yaml (make bundle)

[1] https://github.com/opendatahub-io/opendatahub-operator/blob/13a7e822c0c75f361c319f8256a2d199d031d97c/pkg/deploy/deploy.go#L199

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
ykaliuta added a commit to ykaliuta/opendatahub-operator that referenced this issue Nov 9, 2023
@ykaliuta
DSC controller: manage missing resources previously defined v1
5347eb3 
Add the following resources to manage:

- PersistentVolumeClaim
- Service
- DaemonSet
- StatefulSet
- DeploymentConfig
- ImageStream
- BuildConfig
- CustomResourceDefinition
- APIService
- Ingress
- MutatingWebhookConfiguration
- ValidatingWebhookConfiguration
- ServiceAccount

It requires to add them to the scheme in main.go.
Also `go mod tidy` is run to update modules information to make it
buildable (keep bisectable).

Autogenerated files:
- go.mod
- go.sum

Closes: opendatahub-io#637

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
@zdtsw zdtsw closed this as completed in 91fe6f2 Nov 14, 2023
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this issue Nov 15, 2023
@ykaliuta @VaishnaviHire
Add missing resources to manage in DSC controller (opendatahub-io#669)
27d2d47 
* rbac: add permissions for imagestreams, daemonsets, apiservices

Prepare for watching v1 resources (issue opendatahub-io#637)

To enable watching for DaemonSet and APIService (REST api resources
daemonsets and apiservices) reading/watching permissions required
for the operator's role. Otherwise it gets errors like:

```
User "system:serviceaccount:openshift-operators:opendatahub-operator-controller-manager" cannot list resource "daemonsets" in API group "apps" at the cluster scope

E1018 20:00:55.374514       1 reflector.go:140] go/pkg/mod/k8s.io/client-go@v0.26.0/tools/cache/reflector.go:169: Failed to watch *v1.DaemonSet: failed to list *v1.DaemonSet: daemonsets.apps is forbidden: User "system:serviceaccount:openshift-operators:opendatahub-operator-controller-manager" cannot list resource "daemonsets" in API group "apps" at the cluster scope
```

For ImageStream `get` permissing is needed for cli.Get() in deploy's
manageResources()[1], otherwise it does not set
ownersReference (missing the branch apierrs.IsNotFound(err) since
err is related to permissions).

Autogenerated files:
- config/rbac/role.yaml (make manifests)
-
bundle/manifests/opendatahub-operator.clusterserviceversion.yaml (make bundle)

[1] https://github.com/opendatahub-io/opendatahub-operator/blob/13a7e822c0c75f361c319f8256a2d199d031d97c/pkg/deploy/deploy.go#L199

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

* DSC controller: manage missing resources previously defined v1

Add the following resources to manage:

- PersistentVolumeClaim
- Service
- DaemonSet
- StatefulSet
- DeploymentConfig
- ImageStream
- BuildConfig
- CustomResourceDefinition
- APIService
- Ingress
- MutatingWebhookConfiguration
- ValidatingWebhookConfiguration
- ServiceAccount

It requires to add them to the scheme in main.go.
Also `go mod tidy` is run to update modules information to make it
buildable (keep bisectable).

Autogenerated files:
- go.mod
- go.sum

Closes: opendatahub-io#637

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

---------

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
(cherry picked from commit 91fe6f2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ykaliuta ykaliuta

Labels
bug Something isn't working odh-2.5 rhods-2.5
Projects
Internal tracking
Status: Done
ODH Feature Tracking
Status: No status
ODH Platform Planning
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zdtsw @ykaliuta @dchourasia @VaishnaviHire