Apply OVMS as part of dashboard manifests #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdtsw
requested review from
etirelli and
VaishnaviHire
and removed request for
cfchase and
LaVLaS
components/dashboard/dashboard.go
Outdated
| @@ -71,6 +72,15 @@ func (d *Dashboard) ReconcileComponent(owner metav1.Object, cli client.Client, s | |||
| return err | |||
| } | |||
|
|
|||
| // OVMS | |||
| err = deploy.DeployManifestsFromPath(owner, cli, ComponentName, | |||
There was a problem hiding this comment.
This should only be applied for non-odh platforms
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VaishnaviHire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 6704189
into
opendatahub-io:feature-rearchitecture
6 checks passed
zdtsw
added a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
Jul 31, 2023
Apply OVMS template from dashboard for RHODS only (opendatahub-io#382) Splitting distributed workflows component into codeflare and ray. Fixes opendatahub-io#369 (opendatahub-io#377) Add ODHDashboardconfig in dasboard component Add admin group for downstream Signed-off-by: Wen Zhou <wenzhou@redhat.com>
|
ref: #393 |
10 tasks
zdtsw
added a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
Jul 31, 2023
Apply OVMS template from dashboard for RHODS only (opendatahub-io#382) Splitting distributed workflows component into codeflare and ray. Fixes opendatahub-io#369 (opendatahub-io#377) Add ODHDashboardconfig in dasboard component Add admin group for downstream Signed-off-by: Wen Zhou <wenzhou@redhat.com>
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Jul 31, 2023
Apply OVMS template from dashboard for RHODS only (opendatahub-io#382) Splitting distributed workflows component into codeflare and ray. Fixes opendatahub-io#369 (opendatahub-io#377) Add ODHDashboardconfig in dasboard component Add admin group for downstream Signed-off-by: Wen Zhou <wenzhou@redhat.com>
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Jul 31, 2023
Apply OVMS template from dashboard for RHODS only (opendatahub-io#382) Splitting distributed workflows component into codeflare and ray. Fixes opendatahub-io#369 (opendatahub-io#377) Add ODHDashboardconfig in dasboard component Add admin group for downstream Signed-off-by: Wen Zhou <wenzhou@redhat.com>
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Jul 31, 2023
Apply OVMS template from dashboard for RHODS only (opendatahub-io#382) Splitting distributed workflows component into codeflare and ray. Fixes opendatahub-io#369 (opendatahub-io#377) Add ODHDashboardconfig in dasboard component Add admin group for downstream Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 1c16d59)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
from odh-deployer https://github.com/red-hat-data-services/odh-deployer/blob/main/deploy.sh#L341
Along with changes in https://github.com/red-hat-data-services/odh-manifests/pull/437/files
How Has This Been Tested?
Merge criteria: