Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add path for managed version of Workbenches #521

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Add path for managed version of Workbenches #521

merged 2 commits into from
Sep 7, 2023

Conversation

VaishnaviHire
Copy link
Member

@VaishnaviHire VaishnaviHire commented Sep 7, 2023 •
edited

Fixes #522

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested a review from LaVLaS September 7, 2023 19:22
@VaishnaviHire VaishnaviHire changed the title Introduce rhods changes Add path for managed version of Workbenches Sep 7, 2023
etirelli
etirelli approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@etirelli etirelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 7, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: etirelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6833f79 into opendatahub-io:main Sep 7, 2023
5 checks passed
@zdtsw zdtsw mentioned this pull request Sep 8, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etirelli etirelli etirelli approved these changes

@zdtsw zdtsw Awaiting requested review from zdtsw

@LaVLaS LaVLaS Awaiting requested review from LaVLaS

Assignees

@etirelli etirelli

Labels
approved lgtm
Projects
ODH Platform Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Workbenches path for Managed platform
3 participants
@VaishnaviHire @etirelli @openshift-merge-robot