-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add TrustyAI component #596
Conversation
@ruivieira i did a test from your code base
then we do
|
Remove unused GetComponentDevFlags
Thanks @zdtsw. I'll change to env format upstream so it matches the expectation here. |
once that is done, i will do a final test and we can get this PR out |
one more thing @ruivieira could you update https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/components/README.md inthe |
Add TrustyAI to "Integrated Components"
Version 1.10.2 includes the manifests with the params.env in the correct format
@zdtsw We had to wait quite a bit for the CI to finish, after the |
test on local build, looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add TrustyAI component - Update README.md - Version 1.10.2 includes the manifests with the params.env in the correct format (cherry picked from commit affe7e8)
- feat: Add TrustyAI component (opendatahub-io#596) * Add TrustyAI component - Update README.md - Version 1.10.2 includes the manifests with the params.env in the correct format feat(dw): pass down applicationNamespace to ray and codeflare (opendatahub-io#619) - rename ApplyImageParams to ApplyParams with new boolean parameter - only enable ray and codeflare to set applicationNamespace - Update TrustyAI Operator Variable (opendatahub-io#665) - fix: CSV syntax and linter and main branch Signed-off-by: Wen Zhou <wenzhou@redhat.com>
- feat: Add TrustyAI component (opendatahub-io#596) * Add TrustyAI component - Update README.md - Version 1.10.2 includes the manifests with the params.env in the correct format feat(dw): pass down applicationNamespace to ray and codeflare (opendatahub-io#619) - rename ApplyImageParams to ApplyParams with new boolean parameter - only enable ray and codeflare to set applicationNamespace - Update TrustyAI Operator Variable (opendatahub-io#665) - fix: CSV syntax and linter - Remove redundant TrustyAI reconciliation (opendatahub-io#651) Signed-off-by: Wen Zhou <wenzhou@redhat.com>
- feat: Add TrustyAI component (#596) * Add TrustyAI component - Update README.md - Version 1.10.2 includes the manifests with the params.env in the correct format feat(dw): pass down applicationNamespace to ray and codeflare (#619) - rename ApplyImageParams to ApplyParams with new boolean parameter - only enable ray and codeflare to set applicationNamespace - Update TrustyAI Operator Variable (#665) - fix: CSV syntax and linter - Remove redundant TrustyAI reconciliation (#651) Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Rui Vieira <rcardoso@redhat.com>
Description
incubation
branch, rather thanmain
(as feat: Add TrustyAI component #568 did).release/*
branches.How Has This Been Tested?
Tested with sample DSC CR including the new
Merge criteria: