remove: req.namespace is not used for DSC and DSCI #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdtsw
requested review from
VaishnaviHire
and removed request for
etirelli and
LaVLaS
|
/test opendatahub-operator-e2e |
2 similar comments
|
/test opendatahub-operator-e2e |
|
/test opendatahub-operator-e2e |
| @@ -74,15 +74,15 @@ type DataScienceClusterConfig struct { | |||
| // Reconcile is part of the main kubernetes reconciliation loop which aims to | |||
| // move the current state of the cluster closer to the desired state. | |||
| func (r *DataScienceClusterReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) { | |||
| r.Log.Info("Reconciling DataScienceCluster resources", "Request.Namespace", req.Namespace, "Request.Name", req.Name) | |||
| r.Log.Info("Reconciling DataScienceCluster resources", "Request.Namespace", "cluster-wised", "Request.Name", req.Name) | |||
There was a problem hiding this comment.
Should this be cluster-wide ?
There was a problem hiding this comment.
or should just remove it compeletely?
| @@ -61,7 +61,7 @@ type DSCInitializationReconciler struct { | |||
|
|
|||
| // Reconcile contains controller logic specific to DSCInitialization instance updates. | |||
| func (r *DSCInitializationReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) { | |||
| r.Log.Info("Reconciling DSCInitialization.", "DSCInitialization", req.Namespace, "Request.Name", req.Name) | |||
| r.Log.Info("Reconciling DSCInitialization.", "DSCInitialization", "cluster-wised", "Request.Name", req.Name) | |||
|
/test opendatahub-operator-e2e |
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
ykaliuta
approved these changes
Nov 1, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Nov 15, 2023
Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 5de4fd2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #645
Description
update
new image quay.io/wenzhou/opendatahub-operator-catalog:v2.11.645-99
start up
old
test when created 2nd
DSCI instance "rhods-setup2"
How Has This Been Tested?
build image:
quay.io/wenzhou/opendatahub-operator-catalog:v2.10.645-2
Merge criteria: