Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: modelmesh monitoring logic #703

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Nov 6, 2023

Description

fix: #670
only to remove the comments part, then we can sync to main and later to downstream for 2.5/1.36

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 6, 2023
@zdtsw zdtsw merged commit 023d6c4 into opendatahub-io:incubation Nov 6, 2023
6 of 7 checks passed
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Nov 15, 2023
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 023d6c4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

cleanup modelmesh-monitoring for future release
2 participants