update: rewrite func to check operator #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creds to: bartoszmajsak Signed-off-by: Wen Zhou <wenzhou@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zdtsw
added a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
Jan 15, 2024
creds to: @bartoszmajsak Signed-off-by: Wen Zhou <wenzhou@redhat.com>
zdtsw
added a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
Jan 15, 2024
creds to: @bartoszmajsak Signed-off-by: Wen Zhou <wenzhou@redhat.com>
zdtsw
added a commit
to red-hat-data-services/rhods-operator
that referenced
this pull request
Jan 16, 2024
* Add recording and alerting rules for TrustyAI Update SOP url, RHODS to RHOAI Fix trustyai-alerting.rules indentation * fix(kserve): check on multiple depends operators if all pre-installed (opendatahub-io#744) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rewrite func to check operator (opendatahub-io#745) creds to: @bartoszmajsak Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(cleanup): cleans up dependant resources (opendatahub-io#748) * feat: implements failing test for deletion using configmap * fix(cleanup): cleans up dependant resources The code responsible for cleaning up resources on cfg map presence was failing early due to operations on nil list instance of KfDef resources, leading to panic and restart of the pod making an impression that cleanup takes forever * fix(reconcile): requeue only when actual error happens Original code was always causing requeue as even if upgrade.OperatorUninstall(r.Client, r.RestConfig) resulted in nil error (success), it was wrapped in error with message error while operator uninstall: <nil> * fix: reverts img placeholder in kustomize * fix: removes commented out code * fix(features): makes rest config loader more flexible (opendatahub-io#760) * add table of contents to readme (opendatahub-io#769) * Makefile: add clean target (opendatahub-io#733) Add `make clean` which removes build artefacts. At the moment it's ./bin, ./odh-manifests/* and cover.out from test target. Do not remove odh-manifests directory since it is commited to VCS. In the recipe chown of $(LOCALBIN) since setup-envtest makes its dir RO for some reason [1]. Related: opendatahub-io#696 [1] https://github.com/kubernetes-sigs/controller-runtime/blob/main/tools/setup-envtest/store/store.go#L191 Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> * chore: cleanup owns on RS,Pod, daemonset, CRD (opendatahub-io#777) * chore: cleanup owns on RS,Pod, daemonset, CRD * cleanup: remove developmentconfig not in use * chore: move rbac into one file and remove duplicated one --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update(kserve): add monitoring logic (opendatahub-io#782) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * chore(mesh): Use third party service account tokens (opendatahub-io#767) This should allow Service Mesh to run on any OpenShift flavor. Fixes opendatahub-io/kserve#138 Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * chore: change log info for monitoring patch namespace (opendatahub-io#787) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix devflags empty object (opendatahub-io#659) - change DefFlags to pointer type , see reason from example: https://www.sohamkamani.com/golang/omitempty/ - change both in DSC and DSCI * feature: add support for unmanaged and remove for servicemesh and serverless (opendatahub-io#781) * feature: add support for unmanaged and remove for servicemesh and serverless Signed-off-by: Wen Zhou <wenzhou@redhat.com> * Update components/kserve/kserve.go Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * fix(nilpointer): when more than one DSCI CR in cluster (opendatahub-io#756) * fix(nilpointer): when more than one DSCI CR in cluster - use the one with ealiest timestamp as the default one - suggest user to delete other CR but only use default one - only set the extra/wrong DSCI in Error status Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * chore: change label name (opendatahub-io#790) - use a more generaic label than bind to namespace name Signed-off-by: Wen Zhou <wenzhou@redhat.com> * Remove lavlas from OWNERS (opendatahub-io#791) * fix(builder): initializes rest config before invoking any partial builder (opendatahub-io#792) This way we can obtain interact with the cluster from partial builders instead of defering it to Apply phase. * chore: shifts FeatureTracker creation to Feature's Apply phase (opendatahub-io#795) * fix(mesh): disables default network policy management (opendatahub-io#798) * fix: disables default network policy management * fix: returns correct error Co-authored-by: Wen Zhou <wenzhou@redhat.com> --------- Co-authored-by: Wen Zhou <wenzhou@redhat.com> * feat(linters): Enable all linters by default. (opendatahub-io#692) --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> Co-authored-by: Rui Vieira <ruidevieira@googlemail.com> Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> Co-authored-by: Ajay Jaganathan <36824134+AjayJagan@users.noreply.github.com> Co-authored-by: Yauheni Kaliuta <ykaliuta@redhat.com> Co-authored-by: Edgar Hernández <ehernand@redhat.com> Co-authored-by: Landon LaSmith <2432396+LaVLaS@users.noreply.github.com>
zdtsw
added a commit
to red-hat-data-services/rhods-operator
that referenced
this pull request
Jan 19, 2024
* sync: from main to rhoai-2.6 (#163) * Add recording and alerting rules for TrustyAI Update SOP url, RHODS to RHOAI Fix trustyai-alerting.rules indentation * fix(kserve): check on multiple depends operators if all pre-installed (opendatahub-io#744) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rewrite func to check operator (opendatahub-io#745) creds to: @bartoszmajsak Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(cleanup): cleans up dependant resources (opendatahub-io#748) * feat: implements failing test for deletion using configmap * fix(cleanup): cleans up dependant resources The code responsible for cleaning up resources on cfg map presence was failing early due to operations on nil list instance of KfDef resources, leading to panic and restart of the pod making an impression that cleanup takes forever * fix(reconcile): requeue only when actual error happens Original code was always causing requeue as even if upgrade.OperatorUninstall(r.Client, r.RestConfig) resulted in nil error (success), it was wrapped in error with message error while operator uninstall: <nil> * fix: reverts img placeholder in kustomize * fix: removes commented out code * fix(features): makes rest config loader more flexible (opendatahub-io#760) * add table of contents to readme (opendatahub-io#769) * Makefile: add clean target (opendatahub-io#733) Add `make clean` which removes build artefacts. At the moment it's ./bin, ./odh-manifests/* and cover.out from test target. Do not remove odh-manifests directory since it is commited to VCS. In the recipe chown of $(LOCALBIN) since setup-envtest makes its dir RO for some reason [1]. Related: opendatahub-io#696 [1] https://github.com/kubernetes-sigs/controller-runtime/blob/main/tools/setup-envtest/store/store.go#L191 Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> * chore: cleanup owns on RS,Pod, daemonset, CRD (opendatahub-io#777) * chore: cleanup owns on RS,Pod, daemonset, CRD * cleanup: remove developmentconfig not in use * chore: move rbac into one file and remove duplicated one --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update(kserve): add monitoring logic (opendatahub-io#782) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * chore(mesh): Use third party service account tokens (opendatahub-io#767) This should allow Service Mesh to run on any OpenShift flavor. Fixes opendatahub-io/kserve#138 Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * chore: change log info for monitoring patch namespace (opendatahub-io#787) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix devflags empty object (opendatahub-io#659) - change DefFlags to pointer type , see reason from example: https://www.sohamkamani.com/golang/omitempty/ - change both in DSC and DSCI * feature: add support for unmanaged and remove for servicemesh and serverless (opendatahub-io#781) * feature: add support for unmanaged and remove for servicemesh and serverless Signed-off-by: Wen Zhou <wenzhou@redhat.com> * Update components/kserve/kserve.go Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * fix(nilpointer): when more than one DSCI CR in cluster (opendatahub-io#756) * fix(nilpointer): when more than one DSCI CR in cluster - use the one with ealiest timestamp as the default one - suggest user to delete other CR but only use default one - only set the extra/wrong DSCI in Error status Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * chore: change label name (opendatahub-io#790) - use a more generaic label than bind to namespace name Signed-off-by: Wen Zhou <wenzhou@redhat.com> * Remove lavlas from OWNERS (opendatahub-io#791) * fix(builder): initializes rest config before invoking any partial builder (opendatahub-io#792) This way we can obtain interact with the cluster from partial builders instead of defering it to Apply phase. * chore: shifts FeatureTracker creation to Feature's Apply phase (opendatahub-io#795) * fix(mesh): disables default network policy management (opendatahub-io#798) * fix: disables default network policy management * fix: returns correct error Co-authored-by: Wen Zhou <wenzhou@redhat.com> --------- Co-authored-by: Wen Zhou <wenzhou@redhat.com> * feat(linters): Enable all linters by default. (opendatahub-io#692) --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> Co-authored-by: Rui Vieira <ruidevieira@googlemail.com> Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> Co-authored-by: Ajay Jaganathan <36824134+AjayJagan@users.noreply.github.com> Co-authored-by: Yauheni Kaliuta <ykaliuta@redhat.com> Co-authored-by: Edgar Hernández <ehernand@redhat.com> Co-authored-by: Landon LaSmith <2432396+LaVLaS@users.noreply.github.com> * update: rebranding for rhoai from rhods (#160) * update: rebranding for rhoai from rhods Signed-off-by: Wen Zhou <wenzhou@redhat.com> * Update: new icon data and link to dashboard icon Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: couple of changes (#164) * fix: couple of changes - change from 2.5 missing on 2.6 - version/branch from components - generated bundle with rbac - linter Signed-off-by: Wen Zhou <wenzhou@redhat.com> * [cherry-pick]: odh opendatahub-io#809 Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update(trustyai): set component by default as Managed as GA in 2.6 Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> Co-authored-by: Rui Vieira <ruidevieira@googlemail.com> Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> Co-authored-by: Ajay Jaganathan <36824134+AjayJagan@users.noreply.github.com> Co-authored-by: Yauheni Kaliuta <ykaliuta@redhat.com> Co-authored-by: Edgar Hernández <ehernand@redhat.com> Co-authored-by: Landon LaSmith <2432396+LaVLaS@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
creds to: @bartoszmajsak
Description
follow up conversation from https://github.com/opendatahub-io/opendatahub-operator/pull/744/files#diff-52960d562b25c15c5b2e2531c0fcfe9b990715a0b9897e4fa9126d3832020add
How Has This Been Tested?
Merge criteria: