Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(GH): enabled PR comments by linter bot #865

Merged
merged 2 commits into from
Feb 14, 2024
Merged

update(GH): enabled PR comments by linter bot #865

merged 2 commits into from
Feb 14, 2024

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Feb 14, 2024

#864 (comment)

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@zdtsw
update(GH): enabled PR comments by linter bot
f6838ce 
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@zdtsw zdtsw mentioned this pull request Feb 14, 2024
Merged
3 tasks
@zdtsw @bartoszmajsak
Update .github/workflows/linter.yaml
c34e4c1 
Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com>
bartoszmajsak
bartoszmajsak approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@bartoszmajsak bartoszmajsak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@openshift-ci openshift-ci bot added the lgtm label Feb 14, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bartoszmajsak
Once this PR has been reviewed and has the lgtm label, please assign etirelli for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw merged commit 45638fd into opendatahub-io:incubation Feb 14, 2024
6 of 7 checks passed
@bartoszmajsak bartoszmajsak mentioned this pull request Mar 13, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartoszmajsak bartoszmajsak bartoszmajsak approved these changes

@etirelli etirelli Awaiting requested review from etirelli

@VaishnaviHire VaishnaviHire Awaiting requested review from VaishnaviHire

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan

Assignees

@bartoszmajsak bartoszmajsak

Labels
lgtm
Projects
ODH Platform Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zdtsw @bartoszmajsak