fix(feature): use correct error variable name #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @iNecas. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
VaishnaviHire
approved these changes
Feb 26, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VaishnaviHire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
VaishnaviHire
merged commit 0d8bd14
into
opendatahub-io:incubation
6 of 7 checks passed
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Feb 27, 2024
(cherry picked from commit 0d8bd14)
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Feb 27, 2024
(cherry picked from commit 0d8bd14)
zdtsw
added a commit
to red-hat-data-services/rhods-operator
that referenced
this pull request
Mar 1, 2024
* Update Owners and Owwners-aliases (opendatahub-io#869) (cherry picked from commit 7f477a3) * fix(DSC): do not reconcile resource if it has a special annotation (opendatahub-io#879) * fix(DSC+Kserve): do not reconcile inferenceservice-config for rawdeployment Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: wrong logic Signed-off-by: Wen Zhou <wenzhou@redhat.com> * feat(deploy): do not set ownerreference if resource has sepcial annotation to false Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: change logic to --if kind is CRD do not care annotation * update: change logic - we still set ownerreference on resources - we only skip reconcile if resource has defined annotation Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(typo) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * Update: limite scope of annoation to only kserve resource for now Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 20f4ad0) * fix(feature): use correct error variable name (opendatahub-io#882) (cherry picked from commit 0d8bd14) * allow setting default deployment mode for Kserve in DSC (opendatahub-io#864) * allow setting default deployment mode for Kserve in DSC Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * move kserve config logic to separate file + enhancements Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * revert dev image set in operator CSV Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * only setup kserve config if component is enabled Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * bug fix Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * address PR feedback Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * cleanup Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * fix lint error Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * set default value for Kserve defaultDeploymentMode to be empty Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * more pr feedback Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * update bundle Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * enhance documentation Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * add readme for dev preview Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> --------- Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> (cherry picked from commit cebd287) * Update bundle --------- Co-authored-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Ivan Necas <necasik@gmail.com> Co-authored-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
ykaliuta
pushed a commit
to ykaliuta/opendatahub-operator
that referenced
this pull request
Mar 5, 2024
github-actions bot
pushed a commit
to ykaliuta/opendatahub-operator
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit 24cfcf4)
github-actions bot
pushed a commit
to ykaliuta/opendatahub-operator
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit 24cfcf4)
github-actions bot
pushed a commit
to ykaliuta/opendatahub-operator
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit 24cfcf4)
ykaliuta
pushed a commit
to ykaliuta/opendatahub-operator
that referenced
this pull request
Mar 6, 2024
github-actions bot
pushed a commit
to ykaliuta/opendatahub-operator
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit 7fedddc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small fix for error noticed when playing around.
How Has This Been Tested?
Due to size of the change, just checked the code compiles and runs.
Merge criteria: