feat(dspv2): update manifests path for new overlay struct #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
|
re-testing to see if it works with "main" dspo after new commits. if it works, it is fine to get this PR out |
VaishnaviHire
approved these changes
Mar 8, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VaishnaviHire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zdtsw
added a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
Mar 13, 2024
…b-io#891) * feat(dspv2): update manifests path Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove apply on "base" since overlays/odh does include "base" Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com>
zdtsw
added a commit
to red-hat-data-services/rhods-operator
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref : https://issues.redhat.com/browse/RHOAIENG-4223
How Has This Been Tested?
NEW
also manual tested with new build quay.io/wenzhou/opendatahub-operator-catalog:v2.9.3309-2 for ODH and it works now.
OLD
live build with dspo v2.0.0 tag
quay.io/wenzhou/opendatahub-operator-catalog:v2.9.3309-1
I did some local fix for the broken manifests from dspv2 repo, so the change in this PR is working, but we need to sort out problem in dpsv2 first
Merge criteria: