Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trustbundle): do not use namespace which is in termination status #900

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Mar 7, 2024

Description

ref: https://issues.redhat.com/browse/RHOAIENG-4233

How Has This Been Tested?

live build quay.io/wenzhou/opendatahub-operator-catalog:v2.9.4233-1

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 8, 2024
@VaishnaviHire VaishnaviHire merged commit 1bf33f9 into opendatahub-io:incubation Mar 8, 2024
6 of 7 checks passed
zdtsw added a commit to zdtsw-forking/rhods-operator that referenced this pull request Mar 15, 2024
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Mar 19, 2024
…opendatahub-io#900)

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 1ad4906)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants