Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): add app for ODH base to deploy #938

Merged

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Mar 25, 2024

  • jupyter-install-python-packages jupyter-update-server-settings jupyter-use-s3-bucket-data jupyter-view-installed-packages OdhDocument
  • jupyter OdhApplication
  • deploy-python-model and create-jupyter-notebook OdhQuickStart

Description

to fix odh-nightly build with missing default resource
https://redhat-internal.slack.com/archives/C05NXTEHLGY/p1711380633005149

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

- jupyter-install-python-packages OdhDocument
- jupyter OdhApplication
- deploy-python-model and create-jupyter-notebook OdhQuickStart

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@VaishnaviHire
Copy link
Member

Tested this, and I can see the dashboard resources on fresh install

Screenshot 2024-03-26 at 10 42 41 AM

Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b151ff2 into opendatahub-io:incubation Mar 26, 2024
8 checks passed
zdtsw added a commit to zdtsw-forking/rhods-operator that referenced this pull request Apr 3, 2024
- jupyter-install-python-packages OdhDocument
- jupyter OdhApplication
- deploy-python-model and create-jupyter-notebook OdhQuickStart

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
zdtsw added a commit to zdtsw-forking/rhods-operator that referenced this pull request Apr 23, 2024
- jupyter-install-python-packages OdhDocument
- jupyter OdhApplication
- deploy-python-model and create-jupyter-notebook OdhQuickStart

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants