Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update(rbac): remove MCAD, Appwrapper, instascales related permission in operator #958

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Apr 8, 2024

ref: https://issues.redhat.com/browse/RHOAIENG-5129

CFO has removed MCAD and Appwrapper (?) instascales CRD in their code
we should cleanup such rbac in operator

Description

a side piece: golinter failed with reusing old cache to get this PR "green" i update the cache part in GH action.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@zdtsw zdtsw requested review from astefanutti, anishasthana and HumairAK and removed request for etirelli and ajaypratap003 April 8, 2024 12:10
@zdtsw
Copy link
Member Author

zdtsw commented Apr 8, 2024

to check if this is ok to remove "mcad" and "appwrapper" which might impact pipeline as well @HumairAK

@zdtsw
Copy link
Member Author

zdtsw commented Apr 8, 2024

/retest

@zdtsw
Copy link
Member Author

zdtsw commented Apr 8, 2024

/test opendatahub-operator-e2e

@zdtsw zdtsw changed the title Update(rbac): MCAD and Appwrapper releated permission Update(rbac): remove MCAD and Appwrapper related permission in operator Apr 9, 2024
@zdtsw zdtsw changed the title Update(rbac): remove MCAD and Appwrapper related permission in operator Update(rbac): remove MCAD, Appwrapper, instascales related permission in operator Apr 9, 2024
@zdtsw zdtsw requested a review from sutaakar April 9, 2024 14:07
Copy link

openshift-ci bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sutaakar
Once this PR has been reviewed and has the lgtm label, please ask for approval from zdtsw. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw
Copy link
Member Author

zdtsw commented Apr 9, 2024

/test opendatahub-operator-e2e

@zdtsw
Copy link
Member Author

zdtsw commented Apr 10, 2024

seems the go-linter cache is causing problem for this PR, run it in my forked repo with green result https://github.com/zdtsw-forking/opendatahub-operator/actions/runs/8627717924/job/23648227066

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that removing these resources from RBAC doesn't affect DSP logic.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 10, 2024
@zdtsw zdtsw merged commit d6a50ab into opendatahub-io:incubation Apr 10, 2024
7 of 8 checks passed
zdtsw added a commit to zdtsw-forking/rhods-operator that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants