-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update(rbac): remove MCAD, Appwrapper, instascales related permission in operator #958
Conversation
to check if this is ok to remove "mcad" and "appwrapper" which might impact pipeline as well @HumairAK |
/retest |
/test opendatahub-operator-e2e |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sutaakar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test opendatahub-operator-e2e |
seems the go-linter cache is causing problem for this PR, run it in my forked repo with green result https://github.com/zdtsw-forking/opendatahub-operator/actions/runs/8627717924/job/23648227066 |
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming that removing these resources from RBAC doesn't affect DSP logic.
/lgtm
…pendatahub-io#958) Signed-off-by: Wen Zhou <wenzhou@redhat.com>
ref: https://issues.redhat.com/browse/RHOAIENG-5129
CFO has removed MCAD and Appwrapper (?) instascales CRD in their code
we should cleanup such rbac in operator
Description
a side piece: golinter failed with reusing old cache to get this PR "green" i update the cache part in GH action.
How Has This Been Tested?
Merge criteria: