chore: cleanup duplicated functions packages and add more for godoc #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move GetPlatform() from deploy package to cluster package - move const ManagedRhods SelfManagedRhods OpenDataHub from deploy to cluster package - move WaitForDeploymentAvailable() monitoring package to cluster package - remove monitoring package - move UpdatePodSecurityRolebinding() from common package to cluster package - deprecate GetDomain from common package, to only use GetDomain from cluster package. - remove gvk package, move its GVK to cluster package - move DeleteExistingSubscription() from deploy package to upgrade package - do not export getSubscription() Signed-off-by: Wen Zhou <wenzhou@redhat.com>
zdtsw
requested review from
ykaliuta and
VaishnaviHire
and removed request for
harshad16 and
israel-hdez
ykaliuta
reviewed
Apr 22, 2024
zdtsw
force-pushed
the
chore_48
branch
2 times, most recently
from
0985042
to
aa36cec
Compare
ykaliuta
reviewed
Apr 22, 2024
ykaliuta
reviewed
Apr 22, 2024
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
ykaliuta
reviewed
Apr 23, 2024
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
ykaliuta
approved these changes
Apr 23, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 96c85f2
into
opendatahub-io:incubation
8 checks passed
zdtsw
added a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
May 9, 2024
…pendatahub-io#981) * chore: cleanup duplicated functions/package and add godoc - move GetPlatform() from deploy package to cluster package - move const ManagedRhods SelfManagedRhods OpenDataHub from deploy to cluster package - move WaitForDeploymentAvailable() monitoring package to cluster package - remove monitoring package - move UpdatePodSecurityRolebinding() from common package to cluster package - deprecate GetDomain from common package, to only use GetDomain from cluster package. - remove gvk package, move its GVK to cluster package - move DeleteExistingSubscription() from deploy package to upgrade package - do not export getSubscription() Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove gvk into one file but under cluster package Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rename variable, removing GVK from it Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move gvk into a sub package under cluster Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
local build quay.io/wenzhou/opendatahub-operator-catalog:v2.10.0-48
Merge criteria: