chore(cleanup): remove cleanup functions for upgrade from v1 to v2 #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdtsw
requested review from
VaishnaviHire and
AjayJagan
and removed request for
ykaliuta and
ajaypratap003
|
i add 2.12 label here but it is not a high prio ticket, we can wait if need more eyes on this |
- in the current v2 version, we only support from v2.4 and so on as From - old kfdef CRs will be either cleanedup by v2.4 as upgrade or not even in the cluster from clean installation - move createdefaultDSC caller into main - move unsetownerreference into cleanupexistingresource Signed-off-by: Wen Zhou <wenzhou@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VaishnaviHire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test opendatahub-operator-e2e |
openshift-merge-bot
bot
merged commit 1abe316
into
opendatahub-io:incubation
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://issues.redhat.com/browse/RHOAIENG-6571
Description
How Has This Been Tested?
local build quay.io/wenzhou/opendatahub-operator-catalog:v2.10.0-13
Merge criteria: