chore: passing down ctx in the chain than placeholder TODO() #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
ykaliuta
reviewed
Apr 29, 2024
components/dashboard/dashboard.go
Outdated
| @@ -276,7 +276,7 @@ func (d *Dashboard) deployConsoleLink(cli client.Client, owner metav1.Object, pl | |||
| pathConsoleLink := filepath.Join(manifestsPath, "consolelink.yaml") | |||
|
|
|||
| consoleRoute := &routev1.Route{} | |||
| if err := cli.Get(context.TODO(), client.ObjectKey{Name: NameConsoleLink, Namespace: NamespaceConsoleLink}, consoleRoute); err != nil { | |||
| if err := cli.Get(context.Background(), client.ObjectKey{Name: NameConsoleLink, Namespace: NamespaceConsoleLink}, consoleRoute); err != nil { | |||
pkg/cluster/cluster_config.go
Outdated
| @@ -17,11 +17,11 @@ import ( | |||
|
|
|||
| // +kubebuilder:rbac:groups="config.openshift.io",resources=ingresses,verbs=get | |||
|
|
|||
| func GetDomain(c client.Client) (string, error) { | |||
There was a problem hiding this comment.
Actually, unrelated change.
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
ykaliuta
approved these changes
Apr 29, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit ec07da3
into
opendatahub-io:incubation
8 checks passed
zdtsw
added a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
May 9, 2024
…ahub-io#990) * chore: passing down ctx in the chain than placeholder TODO() Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: add missing one Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: revert name back Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have context defined and pass from upper caller, this is just to make sure the ones we set to TODO can be using ctx
Description
How Has This Been Tested?
Merge criteria: