Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHODS-12555] - CVE-2023-44487 #20

Merged
merged 1 commit into from Oct 20, 2023

Conversation

spolti
Copy link
Member

@spolti spolti commented Oct 18, 2023

Address the CVE-2023-44487

Description

How Has This Been Tested?

Snyk scan result:

$ snyk test
...
✔ Tested 160 dependencies for known issues, no vulnerable paths found.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@spolti
Copy link
Member Author

spolti commented Oct 19, 2023

@spolti spolti force-pushed the RHODS-12555 branch 3 times, most recently from 3bb9078 to a616475 Compare October 19, 2023 15:51
@spolti spolti linked an issue Oct 19, 2023 that may be closed by this pull request
@spolti spolti force-pushed the RHODS-12555 branch 8 times, most recently from 2caec8d to 0f1b908 Compare October 19, 2023 17:20
Plus:

Fixes lint issues:

- Can't run linter goanalysis_metalinter: goanalysis_metalinter: buildir: package "netip" (isInitialPkg: false, needAnalyzeSource: true): in net/netip.AddrFromSlice: cannot convert Load <[]byte> t0 ([]byte) to [4]byte

Warnings:

WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.

Signed-off-by: Spolti <fspolti@redhat.com>
Copy link

@VedantMahabaleshwarkar VedantMahabaleshwarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spolti, VedantMahabaleshwarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [VedantMahabaleshwarkar,spolti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 4c5fb80 into opendatahub-io:main Oct 20, 2023
7 checks passed
@spolti spolti mentioned this pull request Oct 20, 2023
3 tasks
@spolti spolti mentioned this pull request Oct 20, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVE fix for all repos
2 participants