This repository has been archived by the owner on Feb 12, 2023. It is now read-only.
Issue 391 fix http 302 redirects behind proxy #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
yanokwa
approved these changes
Jan 29, 2019
- When Aggregate is running behind a proxy, Swing will generate wrong Location URLs (wrong domain, wrong port number, or even removing the port number) - Also, make the multimode and the change password redirect urls static and absolute to leave no space for Swing messing up stuff (the tradeoff is coupling the multimode login servlet to the actual location of the redirected pages, which is not desirable under normal circumstances)
yanokwa
pushed a commit
to yanokwa/odk-aggregate
that referenced
this pull request
Jan 29, 2019
- When Aggregate is running behind a proxy, Swing will generate wrong Location URLs (wrong domain, wrong port number, or even removing the port number) - Also, make the multimode and the change password redirect urls static and absolute to leave no space for Swing messing up stuff (the tradeoff is coupling the multimode login servlet to the actual location of the redirected pages, which is not desirable under normal circumstances)
yanokwa
pushed a commit
to yanokwa/odk-aggregate
that referenced
this pull request
Jan 31, 2019
- When Aggregate is running behind a proxy, Swing will generate wrong Location URLs (wrong domain, wrong port number, or even removing the port number) - Also, make the multimode and the change password redirect urls static and absolute to leave no space for Swing messing up stuff (the tradeoff is coupling the multimode login servlet to the actual location of the redirected pages, which is not desirable under normal circumstances)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #391
Build on top of #390. See just the last commit
What has been done to verify that this works as intended?
To check that this works, you have to verify that logging in and changing the administrator password works as expected.
I've verified it in the local dev server (gradle), with the local cloudconfig stack.
I'm testing it on DO as well. Will update this when I get the results.
Why is this the best possible solution? Were any other approaches considered?
This bug is related to how Swing builds redirection URLs with the
HttpServletResponse.sendRedirect()method.When Aggregate is running behind a proxy, the URLs Swing generates have the wrong domain, wrong port, or they can lack the port number, which won't work.
After searching for uses of
sendRedirect()in the code, I've seen a few of them that could be replaced by manually setting the redirection response:set the status to 302
set a
Locationheader with an absolute path, but without setting the domain&portThis works around the issue, and it doesn't affect to normal Aggregate setups without proxies.
Are there any risks to merging this code? If so, what are they?
Nope.
Do we need any specific form for testing your changes? If so, please attach one
Nope.
Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.
No.