Skip to content
This repository has been archived by the owner on Apr 16, 2022. It is now read-only.

Export button is disabled after first pull because no default configuration is set #628

Closed
lognaturel opened this issue Sep 4, 2018 · 5 comments

Comments

@lognaturel
Copy link
Member

After a user has pulled some forms, they will often want to export those forms. Now that the default configuration is hidden behind a button, it's not as clear that they need to set values there. They may check a form, try to tap the Export button and find that they're stuck. Nothing indicates that the problem is that there's no configuration set.

Some options:

  • when a form is selected, if no default configuration is set, add text in a dialog or above the set configuration button to indicate a configuration is required
  • enable the export button but when it's clicked, show a dialog indicating a configuration is required

I can see this being a dead end for users so we may want to address it before the release?

@ggalmazor
Copy link
Contributor

I like the idea of enabling the export button and showing a dialog. We could tell the user what's missing. It might be the output dir, or it might be that she hasn't selected any form yet. In future releases, we could even warn about missing private keys for encrypted forms!

Having a default configuration is not strictly required. It would be OK to have a custom conf defined for every selected form, and that would enable the button in the current build.

@lognaturel
Copy link
Member Author

Ahh, right, there are lots of ways to get out of that state.

Agreed that always enabling the export button and then giving some hints on how to proceed if not enough information is set seems like a good approach.

@ggalmazor
Copy link
Contributor

ggalmazor commented Sep 4, 2018

OK! Tomorrow I'll work on a PR for this. It should be easy to do since we already have an ExportConfiguration.getErrors() that would give us the information we want to show in the dialog.

@ggalmazor ggalmazor self-assigned this Sep 4, 2018
@lognaturel
Copy link
Member Author

Sounds great! That will give @yanokwa a bit to see if he has any other thoughts on this.

@yanokwa
Copy link
Member

yanokwa commented Sep 5, 2018

Let's go with enabling the export button and showing a dialog. Feels more natural to warn the user when they are doing something unexpected than to put text in a UI that they won't read.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants