Skip to content
This repository has been archived by the owner on Apr 16, 2022. It is now read-only.

Code improvement - ExportForms #639

Open
ggalmazor opened this issue Sep 12, 2018 · 0 comments
Open

Code improvement - ExportForms #639

ggalmazor opened this issue Sep 12, 2018 · 0 comments

Comments

@ggalmazor
Copy link
Contributor

#603 introduced some changes that highlight the need for refactoring ExportForms.load() to make it more concise and improve semantics.

There's also the question about what should BriefcasePreferences.hasKey() return in case the key exists but the value is null or an empty string. My guts say that we should return false, since we don't really know how the Java Preferences system handles removing keys, for example.

@ggalmazor ggalmazor changed the title Code cleanup - ExportForms Code improvement - ExportForms Sep 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant