You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 16, 2022. It is now read-only.
#603 introduced some changes that highlight the need for refactoring ExportForms.load() to make it more concise and improve semantics.
There's also the question about what should BriefcasePreferences.hasKey() return in case the key exists but the value is null or an empty string. My guts say that we should return false, since we don't really know how the Java Preferences system handles removing keys, for example.
The text was updated successfully, but these errors were encountered:
ggalmazor
changed the title
Code cleanup - ExportForms
Code improvement - ExportForms
Sep 12, 2018
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
#603 introduced some changes that highlight the need for refactoring
ExportForms.load()
to make it more concise and improve semantics.There's also the question about what should
BriefcasePreferences.hasKey()
return in case the key exists but the value is null or an empty string. My guts say that we should returnfalse
, since we don't really know how the Java Preferences system handles removing keys, for example.The text was updated successfully, but these errors were encountered: