Backups status incorrect given fresh configuration

[issa-tseng]

This result seems to violate the "If backups have been configured but no runs have happened since they were most recently set…" criteria in this document.

[matthew-white]

Ah interesting. I think the issue has to do with how Frontend identifies which backup attempts correspond to the latest config. (Code here.) I think what's happening in the example above is that Frontend is categorizing those failed backup attempts as corresponding to the latest config. Failed backup attempts do not have a configSetAt property, which makes identifying which backup attempts correspond to the latest config slightly tricky. However, I'm thinking that we can also use the loggedAt property to filter out backup attempts from before the latest config. Does that sound right? I think if I change the recentForConfig() method, the rest of the logic should still work.

[issa-tseng]

oh. i can see if always setting configSetAt is feasible.

[matthew-white]

After discussing with @clint-tseng, it does seem like it can't be guaranteed that configSetAt will be set for failed backup attempts. However, I think we can make use of loggedAt to address the example above and cases like it.

One case we haven't figured out is what to do if the config is changed while a backup is in progress. In that case, Frontend may associate a failed backup attempt with the wrong config. However, this case should be pretty unlikely. In case it does occur, we may want to take a conservative approach, reporting the failed backup attempt even if we're not sure whether it was a result of the most recent config or a result of a previous config.