Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields with calculations in field lists are not updated as calculated value changes #3211

Closed
lognaturel opened this issue Jul 16, 2019 · 4 comments · Fixed by #3745
Closed
Assignees
Milestone

Comments

@lognaturel
Copy link
Member

lognaturel commented Jul 16, 2019

Software and hardware versions

Collect v1.22+

Problem description

If a field in a field list has a calculation, its value should update as the calculated value changes. It does not.

See failing test at https://github.com/opendatakit/collect/blob/e1a726ef6ca5a9c95b4abd3569a04f97e3193c24/collect_app/src/androidTest/java/org/odk/collect/android/formentry/FieldListUpdateTest.java#L185

Note: the comment says "calculation doesn't seem to be updated whether or not there's a fieldlist" but now it looks to me like it is updated. See visible_calculate.xlsx

Steps to reproduce the problem

Open a form such as visible_calculate.xlsx. Change the value of the "Foo" field.

Expected behavior

The "Foo length" field should update as the "Foo" field's value changes. Interestingly, even navigating away from the field list and back to it doesn't update the value.

@lognaturel lognaturel self-assigned this Jul 16, 2019
@getodk-bot
Copy link
Member

getodk-bot commented Jul 26, 2019

Hello @lognaturel, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 15 days.

You can reclaim this issue or claim any other issue by commenting @opendatakit-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@lognaturel
Copy link
Member Author

Yeah, yeah, @opendatakit-bot, I'm behind on things, I know.

@getodk-bot
Copy link
Member

getodk-bot commented Jan 23, 2020

Hello @grzesiek2010, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 15 days.

You can reclaim this issue or claim any other issue by commenting @opendatakit-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@lognaturel lognaturel added this to Other to do in Current Release Feb 17, 2020
@lognaturel lognaturel moved this from Other to do to Grzegorz to do in Current Release Feb 18, 2020
@grzesiek2010 grzesiek2010 self-assigned this Mar 12, 2020
@getodk-bot
Copy link
Member

Hello @grzesiek2010, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 10 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 5 days.

If you've decided to work on something else, simply comment @opendatakit-bot unclaim so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Open Data Kit!

@grzesiek2010 grzesiek2010 moved this from Grzegorz to do to In progress in Current Release Mar 25, 2020
@grzesiek2010 grzesiek2010 moved this from In progress to Review in progress in Current Release Mar 25, 2020
@grzesiek2010 grzesiek2010 moved this from Review in progress to Needs Quality Assurance in Current Release Apr 2, 2020
Current Release automation moved this from Needs Quality Assurance to Done Apr 6, 2020
@lognaturel lognaturel added this to the v1.27 milestone Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants