Fix : Error logs in code segments #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lognaturel
requested changes
Mar 8, 2018
| @@ -134,13 +134,13 @@ public boolean canSetUpdateIntervals() { | |||
| @Override | |||
| public void setUpdateIntervals(long updateInterval, long fastestUpdateInterval) { | |||
| // Do nothing. | |||
| Timber.e("Can't set updateInterval on AndroidLocationClient. You should check canSetUpdateIntervals before calling this method."); | |||
There was a problem hiding this comment.
Calling setUpdateIntervals would actually be an error in Collect code so this should be logged at level e.
|
did the changes @lognaturel . Please review |
lognaturel
approved these changes
Mar 9, 2018
shobhitagarwal1612
pushed a commit
to shobhitagarwal1612/collect
that referenced
this pull request
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1956
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
Uses
Timber.dandTimber.iin place ofTimber.e.Are there any risks to merging this code? If so, what are they?
No
Do we need any specific form for testing your changes? If so, please attach one.
No
@lognaturel @grzesiek2010 please review