Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify and test or store tricky forms to prevent regressions #221

Closed
lognaturel opened this issue Nov 15, 2017 · 2 comments
Closed

Identify and test or store tricky forms to prevent regressions #221

lognaturel opened this issue Nov 15, 2017 · 2 comments

Comments

@lognaturel
Copy link
Member

For example: https://code.google.com/archive/p/opendatakit/issues/888

This will be especially important as we're looking for performance improvements. All of the different DAG implementations stem from balancing strict correctness and speed. The more forms there are to actually verify correctness, the better.

@dcbriccetti @mdudzinski

@lognaturel
Copy link
Member Author

I don't think we have any coverage of predicates that look quite like https://forum.opendatakit.org/t/validate-against-duplicate-entries-within-nested-repeats/5840/2

@lognaturel
Copy link
Member Author

I think @ggalmazor has given us a great start in the smoketests package so we can close this issue. Naturally, there'll always be more to do but now there are good examples and a lot more coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant