Adds unit tests for DBHandler and MainActivity. #33
Conversation
There was a problem hiding this comment.
Overall this is a good start. There are just a few minor things. Keep adding more tests and soon we will have a robust test suite.
In the DBHandlerTest, there should be a @Before or @After method that cleans the db to prevent potential interaction between the tests. In general, it is a good idea to make sure the environment in which tests start in is consistent and predictable.
Another thing that will be a problem, but don't worry about it now, is setting up ODK-X Services for the tests. Since Services needs read/write external storage permissions, they need to be granted before the tests start.
| public class MainActivityTest { | ||
|
|
||
| @Rule | ||
| public GrantPermissionRule grantPermissionRule = GrantPermissionRule.grant("android.permission.CAMERA"); |
There was a problem hiding this comment.
The string literal can be replaced by Manifest.permission.CAMERA
| public void qrCodeIntentTest(){ | ||
| onView(withId(R.id.fab)).perform(click()); | ||
| intended(allOf( | ||
| hasAction("com.google.zxing.client.android.SCAN"))); |
There was a problem hiding this comment.
This literal can be replaced by this constant
|
|
||
| @Before | ||
| public void setUp(){ | ||
| dbHandler = new DBHandler(InstrumentationRegistry.getTargetContext(),null,null,1); |
There was a problem hiding this comment.
getTargetContext is deprecated, check the javadoc for replacement.
| import static org.hamcrest.core.AllOf.allOf; | ||
|
|
||
| @RunWith(AndroidJUnit4.class) | ||
| public class MainActivityTest { |
There was a problem hiding this comment.
This is a test that interacts with the UI, it is a good practice to annotate it with @LargeTest
| public class MainActivityTest { | ||
|
|
||
| @Rule | ||
| public GrantPermissionRule grantPermissionRule = GrantPermissionRule.grant("android.permission.CAMERA"); |
There was a problem hiding this comment.
The MainActivity also needs READ_EXTERNAL_STORAGE
Following tests are covered in this: