Allows to filter on organization and tags #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abulte
approved these changes
Jun 5, 2018
| filters = ( | ||
| HarvestFilter(_('Organization'), 'organization', str, | ||
| _('A CKAN Organization name')), | ||
| HarvestFilter(_('Tag'), 'tags', str, _('A CKAN tag name')), |
There was a problem hiding this comment.
Why tags (plural)? CKAN API weirdness?
There was a problem hiding this comment.
Yes, one of the CKAN API weirdness 😒
udata_ckan/harvesters.py
Outdated
| @@ -134,8 +139,21 @@ def initialize(self): | |||
| # status = self.get_status() | |||
| # fix = status['ckan_version'] < '1.8' | |||
There was a problem hiding this comment.
I hesitate, I wanted to have the minimal scope, but fine to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make use of opendatateam/udata#1716 and:
organizationandtagsRequires opendatateam/udata#1716 (
udatadependency will be updated and cache will be flushed when dependency is merged)