Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

Store geojson format instead of json when relevant #212

Merged
merged 4 commits into from Apr 13, 2022

Conversation

maudetes
Copy link
Contributor

@maudetes maudetes commented Apr 12, 2022

Fix #211

Do you know any historic on why json was used when storing format in udata instead of geojson @abulte?

@maudetes maudetes requested a review from quaxsze April 12, 2022 16:37
@abulte
Copy link
Contributor

abulte commented Apr 12, 2022

Nope. But geojson is json so we can't say it was wrong.

@maudetes maudetes merged commit 4a54c5c into master Apr 13, 2022
@maudetes maudetes deleted the feat/store-geojson-format branch April 13, 2022 07:43
@AntoineAugusti
Copy link

Thank you for doing this! Can you keep us @etalab/transport-tech posted when this will be deployed?

@maudetes
Copy link
Contributor Author

Yes, depending on the priority for you, we could wait for other improvements (incoming modifications on dates) or ship it directly.

@AntoineAugusti
Copy link

@maudetes We already shipped something on transport.data.gouv.fr to go around this issue so it's just a matter of removing our old code (see linked issues/PRs), take your time!

@AntoineAugusti
Copy link

@maudetes @abulte Wondering if this has been released?

@abulte
Copy link
Contributor

abulte commented Sep 7, 2022

@AntoineAugusti
Copy link

I think this is now live on data.gouv.fr, can you confirm?

I picked a random dataset and the format doesn't seem appropriate for the resource named "Export au format GeoJSON" though 😢

@maudetes
Copy link
Contributor Author

Yep, I confirm that this fix is live!
I'm not sure about your example, but there may be an issue with duplicate resources (due to a double / in url). The second one named Export au format GeoJSON is in geojson format.
Another random dataset with geojson format.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put geojson as the format for GeoJSON files
4 participants