Remove metrics computation #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Wait for the metrics pipeline refactoring is complete to ship this) |
|
(Related to datagouv/data.gouv.fr#915) |
maudetes
approved these changes
Sep 20, 2022
| version: '3' | ||
| services: | ||
| piwik: | ||
| image: udata/piwik-test |
There was a problem hiding this comment.
Don't we want to keep a piwik/matomo image for testing and dev purposes?
There was a problem hiding this comment.
I opted for total removal because this image is quite a complex hack that was done specifically to debug metric computations (I should know, I did it ;-)). I don't think it's necessary anymore but YMMV.
12 tasks
|
Yeah! 🚀 ⏲️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prepare for the release of a new
udata-metricsthat handles metrics computation from log files, instead of from Matomo.--
Up until this version, metrics were tentatively computed from Matomo for pretty much every object of a udata instance. We found this method to be pretty inaccurate, since Matomo limits the number of records stored to roughly the most visited 1000 for a given "namespace". There's a way around that by using the data from the Live module of Matomo but it's not enabled on our instance for privacy reasons. We also needed to count hits that Matomo could not know of: resources (files) downloads made directly on our server.
Thus, this module now only does three things:
Metrics computation is now handled by https://github.com/opendatateam/udata-metrics and does not use Matomo as a source.
piwik-update-metricspiwik-current-metricspiwik-yesterday-metrics