Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Matomo attributes #263

Merged

Conversation

nicolaskempf57
Copy link
Contributor

@nicolaskempf57 nicolaskempf57 commented Apr 20, 2023

This PR changes the way we handle recommendations content in Matomo.

Before

Each recommendation type has a content name following the pattern {type} recommendations except external that uses dataset externals.
All recommendations have the same content piece reco because loop.idx is not set.

After

Each recommendation type has a content name following the pattern {type} recommendations including external ones.
All recommendations have a content piece corresponding to the individual piece of content shown :

  • a dataset or reuse recommendation has its title as piece
  • an external recommendation has its url as piece

This allows Matomo to provide metrics for a type of recommendation but also for each piece.

@nicolaskempf57 nicolaskempf57 changed the title Fix/matomo attributes Fix Matomo attributes Apr 20, 2023
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to make sense!

@nicolaskempf57 nicolaskempf57 merged commit c4fe99e into opendatateam:master Apr 25, 2023
1 check passed
@nicolaskempf57 nicolaskempf57 deleted the fix/matomo-attributes branch April 25, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants