Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dataset's topics in index #43

Merged
merged 2 commits into from Aug 25, 2023
Merged

Add dataset's topics in index #43

merged 2 commits into from Aug 25, 2023

Conversation

quaxsze
Copy link
Contributor

@quaxsze quaxsze commented Aug 3, 2023 •
edited

@maudetes maudetes mentioned this pull request Aug 3, 2023
Merged
maudetes
maudetes reviewed Aug 23, 2023
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some tests on this new filter? 🙏

udata_search_service/presentation/api.py Show resolved Hide resolved
@quaxsze quaxsze requested a review from maudetes August 24, 2023 16:24
maudetes
maudetes approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉

@quaxsze quaxsze merged commit 358726e into main Aug 25, 2023
1 check passed
@quaxsze quaxsze deleted the AddDatasetTopics branch August 25, 2023 11:43
@abulte abulte mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maudetes maudetes maudetes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@quaxsze @maudetes