Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce a domain whitelist when resource.filetype is file #1567

Merged
merged 4 commits into from
Apr 10, 2018

Conversation

abulte
Copy link
Contributor

@abulte abulte commented Apr 9, 2018

Fix #988

Migration in etalab/udata-gouvfr#292

Copy link
Contributor

@noirbizarre noirbizarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe switch config name for something a little bit shorter

@@ -93,6 +93,15 @@ The duration used for templates' cache, in minutes.

This is the allowed resources extensions list that user can upload.

### RESOURCES_FILETYPE_FILE_ALLOWED_DOMAINS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a long name, maybe something shorter ? RESOURCES_FILE_ALLOWED_DOMAINS ?

@abulte abulte force-pushed the fix/resource-filetype-coherence branch from b8abefd to 4d0dcaf Compare April 10, 2018 08:09
@abulte abulte merged commit 43ce270 into opendatateam:master Apr 10, 2018
@abulte abulte deleted the fix/resource-filetype-coherence branch April 10, 2018 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants