Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entrypoint-based harvesters #1004

Merged
merged 1 commit into from Jun 26, 2017
Merged

Entrypoint-based harvesters #1004

merged 1 commit into from Jun 26, 2017

Conversation

noirbizarre
Copy link
Contributor

This PR makes harvester declaration entrypoint-based, like themes are.

This avoid using a global dictionnary to stora harvesters.
The documentation has been adapted (and a cookiecutter is coming here

Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo.

@@ -214,6 +212,29 @@ class RandomBackend(BaseBackend):

```

You need to properly expose the harvester as a `udata.harvesters` entrypoint in you `setup.py`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you -> your

@noirbizarre noirbizarre merged commit 377d117 into opendatateam:dev Jun 26, 2017
@noirbizarre noirbizarre deleted the harvester-entrypoint branch June 26, 2017 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants