Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve purge and job command and document them #1039

Merged
merged 1 commit into from Jul 19, 2017
Merged

Improve purge and job command and document them #1039

merged 1 commit into from Jul 19, 2017

Conversation

noirbizarre
Copy link
Contributor

This PR:

  • improve the purge command by allowing to purge only a given model
  • fix the job command in case of keyword arguments
  • document both commands

@noirbizarre noirbizarre added this to the 1.1.1 milestone Jul 18, 2017
davidbgk
davidbgk approved these changes Jul 18, 2017
View reviewed changes
Copy link
Member

@davidbgk davidbgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if purge_* should delete everything but within the latest minutes? hours?

docs/administrative-tasks.md Outdated

## Purge data flagged as deleted

When user delete some data in udata,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

userS or a user deleteS

docs/administrative-tasks.md Outdated

When user delete some data in udata,
it's only flagged as deleted and hidden in the frontend.
This allow the administrative team to undelete data in case of error.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allowS

@noirbizarre
Copy link
Contributor Author

This is configurable: purge jobs are manually defined so you can choose the frequency, every every minutes (does not make any sense), every hour, every day...

@noirbizarre noirbizarre merged commit 622a8d1 into opendatateam:master Jul 19, 2017
@noirbizarre noirbizarre deleted the purge-improvements branch July 19, 2017 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbgk davidbgk davidbgk approved these changes

@abulte abulte Awaiting requested review from abulte

@thom4parisot thom4parisot Awaiting requested review from thom4parisot

@vinyll vinyll Awaiting requested review from vinyll

@thimy thimy Awaiting requested review from thimy

@teleboas teleboas Awaiting requested review from teleboas

Assignees
No one assigned
Labels
bug documentation enhancement
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noirbizarre @davidbgk