Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search): a page without a search query string would break the initialisation of the search form #1053

Merged
merged 1 commit into from
Jul 26, 2017
Merged

fix(search): a page without a search query string would break the initialisation of the search form #1053

merged 1 commit into from
Jul 26, 2017

Conversation

thom4parisot
Copy link
Contributor

@thom4parisot thom4parisot commented Jul 26, 2017 •
edited

In continuity of #1019.

It should be shipped in udata@1.1 to avoid the search to break.

@thom4parisot thom4parisot changed the base branch from master to dev July 26, 2017 08:32
@thom4parisot thom4parisot added this to the 1.1 milestone Jul 26, 2017
@thom4parisot thom4parisot merged commit d1b083c into opendatateam:dev Jul 26, 2017
@thom4parisot thom4parisot deleted the fix/1019 branch July 26, 2017 17:24
@noirbizarre noirbizarre removed the ready label Jul 26, 2017
@abulte
Copy link
Contributor

abulte commented Jul 31, 2017 •
edited

@oncletom #1019 has not been merged into master, no (urgent) need to push this in 1.1.

@thom4parisot thom4parisot removed this from the 1.1 milestone Jul 31, 2017
@thom4parisot
Copy link
Contributor Author

thom4parisot commented Jul 31, 2017 •
edited

@abulte no problem, I removed the milestone — I assumed #1019 was part of v1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbgk davidbgk davidbgk approved these changes

@vinyll vinyll vinyll approved these changes

@noirbizarre noirbizarre Awaiting requested review from noirbizarre

@abulte abulte Awaiting requested review from abulte

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thom4parisot @abulte @davidbgk @vinyll @noirbizarre