Harvest auto schedule #1114
Merged
Harvest auto schedule #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abulte
reviewed
Sep 8, 2017
| @@ -153,28 +154,33 @@ def preview(ident): | |||
| return backend.harvest() | |||
|
|
|||
|
|
|||
| def schedule(ident, minute='*', hour='*', | |||
| def schedule(ident, cron=None, minute='*', hour='*', | |||
There was a problem hiding this comment.
Do we still need the other karkgs? minute, hour...
There was a problem hiding this comment.
Yes, we need it, udata harvest schedule command line use it.
|
Right now in this PR, you can only change it from the commandline (before you could only set it, this PRs ensure it can be changed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs ensures that validated harvest sources are automatically scheduled (using the
HARVEST_DEFAULT_SCHEDULEsetting which is a cron expression) and that they can be rescheduled.