Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that the default language is declared into LANGUAGES #1197

Merged
merged 1 commit into from Oct 4, 2017

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

commented Oct 4, 2017

This PR starts performing config validation and ensures the DEFAULT_LANGUAGE is contained in LANGAGUES

@noirbizarre noirbizarre added this to the 1.2.0 milestone Oct 4, 2017

@noirbizarre noirbizarre requested a review from opendatateam/etalab Oct 4, 2017

@abulte

abulte approved these changes Oct 4, 2017

@@ -15,6 +15,7 @@
- Improve logging for adhoc scripts [#1184](https://github.com/opendatateam/udata/pull/1184)
- Improve URLs validation (support new tlds, unicode URLs...) [#1182](https://github.com/opendatateam/udata/pull/1182)
- Properly serialize empty geometries for zones missing it and prevent leaflet crash on invalid bounds [#1188](https://github.com/opendatateam/udata/pull/1188)
- Start validating some configuration parameters

This comment has been minimized.

Copy link
@abulte

abulte Oct 4, 2017

Member

Missing link

@noirbizarre noirbizarre force-pushed the noirbizarre:i18n-check-config branch from 7cfa93b to edbcac7 Oct 4, 2017

@noirbizarre noirbizarre force-pushed the noirbizarre:i18n-check-config branch from edbcac7 to 20dc143 Oct 4, 2017

@noirbizarre noirbizarre merged commit 951d7c3 into opendatateam:master Oct 4, 2017

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre removed the in progress label Oct 4, 2017

@noirbizarre noirbizarre deleted the noirbizarre:i18n-check-config branch Oct 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.