Improve licenses detection in harvesting #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abulte
approved these changes
Oct 9, 2017
| def guess(cls, text): | ||
| def guess(cls, *strings, **kwargs): | ||
| ''' | ||
| Try to guess a license from a list of strings. |
There was a problem hiding this comment.
Maybe document the default kwarg?
There was a problem hiding this comment.
Or declare it explicitly in the method signature.
There was a problem hiding this comment.
It's not possible to declare explicitely a keyword argument with variable arguments in Python 2 (already tried :/).
I'll add it to the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs improve the
Licence.guess()helper by allowing a list of string and a default fallback license.It also expose the default license as
License.default()All harvesters now use the same algorithm.