Fix the scroll to a discussion sub-thread #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abulte
force-pushed
the
fix/sub-discussion-scroll
branch
from
ad2a70f
to
add3528
Compare
thom4parisot
approved these changes
Oct 10, 2017
thom4parisot
approved these changes
Oct 10, 2017
| @@ -136,7 +136,7 @@ export default { | |||
| this.detailed = true; | |||
| if (index) { | |||
| this.$nextTick(() => { | |||
| this.$scrollTo(`#${discussionIdAttr}-${index}`); | |||
| this.$scrollTo(`#${this.discussionIdAttr}-${index}`); | |||
There was a problem hiding this comment.
A further improvement would be to have an index parameter in the computed.discussionIdAttr to avoid adding it manually everywhere in the page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still have a problem on my local env (when page finishes loading, scroll to top of page) but at least the JS error is fixed by this PR.