Optimize indexation #1215
Merged
Optimize indexation #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abulte
approved these changes
Oct 18, 2017
CHANGELOG.md
Outdated
| @@ -22,6 +22,7 @@ | |||
| - Switch from static theme avatars/placeholders to [identicons](https://en.wikipedia.org/wiki/Identicon) for readability (mostly on discussions) [#1193](https://github.com/opendatateam/udata/pull/1193) | |||
| - Fix the scroll to a discussion sub-thread [#1206](https://github.com/opendatateam/udata/pull/1206) | |||
| - Fix duplication in discussions [migration] [#1209](https://github.com/opendatateam/udata/pull/1209) | |||
| - Optimize a little bit indexation [#1215](https://github.com/opendatateam/udata/pull/1215) | |||
There was a problem hiding this comment.
*Optimize indexation a little bit
udata/core/dataset/search.py
Outdated
| else: | ||
| organization = None |
There was a problem hiding this comment.
Maybe initialize organization, owner and image_url to None before the ifs? If feel more comfortable with this pattern but YMMV.
There was a problem hiding this comment.
You're right, it's much better
|
|
||
| document = { | ||
| 'title': dataset.title, | ||
| 'description': dataset.description, | ||
| 'license': (dataset.license.id | ||
| if dataset.license is not None else None), | ||
| 'license': getattr(dataset.license, 'id', None), |
udata/core/reuse/search.py
Outdated
| owner = User.objects(id=reuse.owner.id).first() | ||
| organization = None | ||
| else: | ||
| organization = None |
There was a problem hiding this comment.
Same remark as above about initialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimize indexation by:
user.role)