Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check only the uncollapsed resources at first on dataset view #1246

Merged

Conversation

abulte
Copy link
Contributor

@abulte abulte commented Oct 26, 2017

This PR ensures only the uncollapsed resources are link checked, until "show all resources" button is clicked.

Could probably be done a little better in a future version: only restrain from triggering uncached checks, not all checks. The gain would be minimal though, since all the resources on the same dataset tend to have the same check:date.

@abulte abulte requested a review from a team October 26, 2017 13:14
@abulte abulte merged commit 6ae1363 into opendatateam:master Oct 26, 2017
@abulte abulte deleted the linkchecker/check-only-visible-resources branch October 26, 2017 15:40
@noirbizarre noirbizarre added this to the 1.2.3 milestone Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants