Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Celery ignore results #1281

Merged
merged 3 commits into from Nov 29, 2017
Merged

Celery ignore results #1281

merged 3 commits into from Nov 29, 2017

Conversation

noirbizarre
Copy link
Contributor

This PR tweaks celery results handling:

  • results are not kept by default anymore and tasks requiring it have to explicitely notify it (harvest tasks which are using chords requires it)
  • default results expiration is lowered to 6 hours instead of the default 24 hours.

@noirbizarre noirbizarre added this to the 1.2.4 milestone Nov 29, 2017
@noirbizarre noirbizarre requested a review from a team November 29, 2017 09:21
abulte
abulte approved these changes Nov 29, 2017
View reviewed changes
CHANGELOG.md Outdated
@@ -4,6 +4,7 @@

- Fix flask_security celery tasks context [#1249](https://github.com/opendatateam/udata/pull/1249)
- Fix `dataset.quality` handling when no format filled [#1265](https://github.com/opendatateam/udata/pull/1265)
- Ignore celery tasks results except for tasks which requires it and lower the default results expiration to 6 hours [#1281](https://github.com/opendatateam/udata/pull/1281)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/requires/require/

@noirbizarre noirbizarre merged commit 6ccf579 into opendatateam:master Nov 29, 2017
@noirbizarre noirbizarre deleted the celery-ignore-results branch November 29, 2017 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abulte abulte abulte approved these changes

Assignees
No one assigned
Labels
enhancement performance quick-win-big-impacts
Projects
None yet
Milestone
1.2.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noirbizarre @abulte