Make terms content an easily customizable markdown content #1285
Conversation
docs/adapting-settings.md
Outdated
| **default**: `'default'` | ||
|
|
||
| The site terms in markdown. It can be either an URL to a markdown content or a local path. | ||
| If this is an URL, the content is downloaded on the first terms page display and cached. |
There was a problem hiding this comment.
How long is it cached? Is it related to another udata setting? Is it done by following HTTP cache instructions?
There was a problem hiding this comment.
udata/cgu.md
Outdated
| @@ -0,0 +1,6 @@ | |||
| # Generic terms and conditions | |||
There was a problem hiding this comment.
cgu.md is based on a french naming (Conditions Générales d'Utilisation). Would not it be more consistent to name it terms.md?
Also, should we rather return a 404 page on the terms page if nothing has been specified? I'd be more comfortable to return nothing rather than a content which cannot be used as is.
Something like udata doctor could be used to list recommended changes to improve udata settings beyond its defaults.
There was a problem hiding this comment.
👍 for terms.md. Not sure about the 404.
|
Nice work :-) Is there part of your work which can be reused in the future to handle more content via remote static pages/markdown resources? |
docs/adapting-settings.md
Outdated
|
|
||
| **default**: `'default'` | ||
|
|
||
| The site terms in markdown. It can be either an URL to a markdown content or a local path. |
There was a problem hiding this comment.
s/It can be either an URL to a markdown content or a local path./It can be either an URL or a local path to a markdown content./
There was a problem hiding this comment.
s/terms/terms and conditions/
udata/cgu.md
Outdated
| @@ -0,0 +1,6 @@ | |||
| # Generic terms and conditions | |||
There was a problem hiding this comment.
👍 for terms.md. Not sure about the 404.
udata/cgu.md
Outdated
|
|
||
| Be excellent to each other. | ||
|
|
||
| You see this content because you don't have provided a proper `SITE_TERMS` |
There was a problem hiding this comment.
s/SITE_TERMS/SITE_TERMS setting/
docs/adapting-settings.md
Outdated
| **default**: `'default'` | ||
|
|
||
| The site terms in markdown. It can be either an URL to a markdown content or a local path. | ||
| If this is an URL, the content is downloaded on the first terms page display and cached. |
There was a problem hiding this comment.
|
@oncletom I think some of this work can/may be reusable for other content but I prefer to factorize when it's required in order to have all parameters. @abulte I switched to About |
|
|
This PR externalize the terms handling.
udata now expect a markdown content into a remote or local file.
The target file is defined by the
SITE_TERMSsetting.It default on an embedded markdown content which indicate to the administrator it needs to define terms.
NB: this prevent
mailto:links to render as links