New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken post edit form page #1295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for the fix but you must revert the form markup/name change
js/components/post/form.vue
Outdated
|
||
export default { | ||
name: 'post-form', | ||
components: {VerticalForm}, | ||
components: { | ||
vform: require('components/form/vertical-form.vue') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As much as possible we avoid inline require
js/components/post/form.vue
Outdated
@@ -1,16 +1,17 @@ | |||
<template> | |||
<div> | |||
<vertical-form v-ref:form :fields="fields" :model="post"></vertical-form> | |||
<vform v-ref:form :fields="fields" :model="post"></vform> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are doing the opposite, ie. transform vfrom
/hform
into vertical-form
horizontal-form
for the following reason:
- this is more explicit
- web component spec prohibe single term markup (you need a dash in a web component markup)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
argh. I was overzealous at getting a homogeneous code from the wrong example.
@noirbizarre revert done |
👌 |
No description provided.