Import css dropdowns handling from udata-gouvfr #1297
Conversation
| } | ||
|
|
||
| // Mobile: display inline when menu is open | ||
| .navbar-collapse.in &.dropdown-hover .dropdown-menu { |
There was a problem hiding this comment.
How do we know this is for mobile? Just by reading the CSS selector, it is not obvious.
There was a problem hiding this comment.
.navbar-collapse.in is the bootstrap selector for the expanded menu on mobile only (.navbar-collapse is always visible on desktop)
This is not obvious (and I had to search), this is why I put the comment.
There was a problem hiding this comment.
BTW, why block the merge and request change ? Do you want me to change something ?
There was a problem hiding this comment.
@noirbizarre ok thanks. I was not sure if there was a more obvious way to signpost this. Something more obvious than a comment. I can live with it :-)
There was a problem hiding this comment.
Some mecanism in bootstrap are a little bit weird to understand :/
This PRs import CSS dropdowns behavior from gouvfr style (it's a ashred behavior) and fix hidden submenus on mobile.