Sanitize mdstrip #1351
Merged
Sanitize mdstrip #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abulte
changed the title
|
Maybe simply use |
|
Hum, actually we should not replace |
abulte
changed the title
|
New version with |
davidbgk
approved these changes
Jan 8, 2018
noirbizarre
approved these changes
Jan 8, 2018
| @@ -100,6 +107,7 @@ def mdstrip(value, length=None, end='…'): | |||
| value = value.split(EXCERPT_TOKEN, 1)[0] | |||
| rendered = md(value) | |||
| text = do_striptags(rendered) | |||
| text = bleach_clean(text) | |||
There was a problem hiding this comment.
Seems to be working. I'm just wondering whether this should after or before the do_striptags
There was a problem hiding this comment.
Somehow do_striptags would reintroduce the injection. I tested because it seemed more logical but...
There was a problem hiding this comment.
Fine to me, I was just wondering the reasonning 👍
noirbizarre
approved these changes
Jan 8, 2018
| @@ -100,6 +107,7 @@ def mdstrip(value, length=None, end='…'): | |||
| value = value.split(EXCERPT_TOKEN, 1)[0] | |||
| rendered = md(value) | |||
| text = do_striptags(rendered) | |||
| text = bleach_clean(text) | |||
There was a problem hiding this comment.
Fine to me, I was just wondering the reasonning 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jinja
do_striptagsresult is not safe to piped into asafefilter, for example when we outputjson_ld.Not totally sure about the impact of this on the rest of the site, but some nasty things happening on a reuse do not happen anymore and the reuse stil displays fine.