Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumping chartjs to v2 #1352

Merged
merged 6 commits into from Jan 9, 2018
Merged

Bumping chartjs to v2 #1352

merged 6 commits into from Jan 9, 2018

Conversation

taniki
Copy link
Contributor

@taniki taniki commented Jan 8, 2018

This time with doughnuts!

noirbizarre
noirbizarre approved these changes Jan 8, 2018
View reviewed changes
Copy link
Contributor

@noirbizarre noirbizarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.
Have you tested everywhere:

  • admin > org
  • admin > dataset
  • front > dashboard
  • front > org > dashboard

@abulte
Copy link
Contributor

abulte commented Jan 9, 2018

Fix #713

@taniki
Copy link
Contributor Author

taniki commented Jan 9, 2018

Just checked pages discussed by @noirbizarre: everything is ok

@taniki taniki merged commit 4066e0d into opendatateam:master Jan 9, 2018
@pyup-bot pyup-bot mentioned this pull request Jan 10, 2018
Merged
@abulte abulte mentioned this pull request Jan 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noirbizarre noirbizarre noirbizarre approved these changes

@abulte abulte abulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taniki @abulte @noirbizarre