Ensure unicode objects are not casted to str but properly encoded #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abulte
approved these changes
Jan 22, 2018
CHANGELOG.md
Outdated
| @@ -7,6 +7,7 @@ | |||
| - `ValueError`s are not hidden anymore by the Bad Request error page, they are logged. [#1382](https://github.com/opendatateam/udata/pull/1382) | |||
| - Spatial encoding fixes: prevent breaking unicode errors. [#1381](https://github.com/opendatateam/udata/pull/1381) | |||
| - Ensure the multiple term search uses a `AND` operator [#1384](https://github.com/opendatateam/udata/pull/1384) | |||
| - Facets encoding fixes: ensure lazy string are propery encoded. [#1388](https://github.com/opendatateam/udata/pull/1388) | |||
There was a problem hiding this comment.
s/string/strings/ or s/are/is/
udata/core/spatial/models.py
Outdated
| @@ -8,7 +8,7 @@ | |||
| from werkzeug import cached_property | |||
|
|
|||
| from udata.app import cache | |||
| from udata.i18n import gettext as _, get_locale, language | |||
| from udata.i18n import gettext as _, lazy_gettext as L_, get_locale, language | |||
There was a problem hiding this comment.
Is L_ a known convention? I'd be more comfortable with l_ since it's a function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More fixes on unicode handling (Remove a double translation and ensure lazy_string are properly encoded in search facets)
Connects to #1381