Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum viable solution to have coherent discussion style for all themes #1393

Merged
merged 1 commit into from Jan 23, 2018
Merged

Minimum viable solution to have coherent discussion style for all themes #1393

merged 1 commit into from Jan 23, 2018

Conversation

noirbizarre
Copy link
Contributor

@noirbizarre noirbizarre commented Jan 22, 2018

This PR import the bare minimum CSS rules from udata-gouvfr to have coherent styling on discussion.
Also namespace discussion for future improvement (and theming ability)

Before

Thread

screenshot-data xps-2018-01-22-20-27-21-608

New discussion form

screenshot-data xps-2018-01-22-21-49-05-289

Thread comment form

screenshot-data xps-2018-01-22-22-11-31-805

After

Thread

screenshot-data xps-2018-01-22-20-23-10-223

New discussion form

screenshot-data xps-2018-01-22-22-09-04-521

Thread comment form

screenshot-data xps-2018-01-22-22-09-31-077

NB: discussion style is a real mess and need some love
NB: resources refactoring will break discussions style if nothing is done until then

@noirbizarre noirbizarre merged commit 71f2ca4 into opendatateam:master Jan 23, 2018
@noirbizarre noirbizarre deleted the fix-discussions-style branch January 23, 2018 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants