Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added link to password change into the admin #1462

Merged
merged 3 commits into from Mar 2, 2018
Merged

Added link to password change into the admin #1462

merged 3 commits into from Mar 2, 2018

Conversation

noirbizarre
Copy link
Contributor

This PR simply add a link to password change into the admin. This is a short term solution.

Long term should be a refactoring of user/me admin page

@@ -81,6 +85,9 @@ export default {
this._handler.remove();
},
methods: {
change_password() {
document.location = '/change';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work if udata is served from a subfolder, does it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but right now, it already can't be served in a subfolder because this pattern is already used in many places.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok :-)

@noirbizarre noirbizarre merged commit 9062c27 into opendatateam:master Mar 2, 2018
@noirbizarre noirbizarre deleted the password-management branch March 2, 2018 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants